Exiv2

Daniel

I've just run a CMake build with MSVC 2005 and that does not attempt to execute svn_version.sh

When I added the feature to include the svn revision in to the the build of Exiv2, I decided that this would not be supported by MSVC. So the code to generate the svn_version.h should not be executed for MSVC builds. So in CMakeLists.txt, you'll find:

IF( NOT MSVC )
   ...
  MESSAGE(STATUS         "generating ${CMAKE_CURRENT_SOURCE_DIR}/src/svn_version.h")
  EXECUTE_PROCESS( WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/src       COMMAND ./svn_version.sh)
ENDIF()

And in version.hpp:

// svn version has not been implemented yet for DevStudio
#if     defined(_MSC_VER)
#define SVN_VERSION 0
#else
#include "svn_version.h" 
#endif

So I'm surprised this is causing you difficulty, as I believe I have engineered things correctly. Are you working on the trunk?

The reason to omit svn for MSVC is the dependency on locating svn.exe. The svn version number feature is intended for development purposes to differentiate different branches and builds. So for MSVC I report svn=0.

MSVC builds can't execute svn_version.sh because it's a bash script and intended for not MSVC environments (cygwin/mingw/linux/macosx).

I'll have to back-track and learn about FIND_PACKAGE(Subversion). As you know, I'm not strong with CMake and don't understand the FIND magic. However, it's important for me to master this as we're about to introduce more optional libraries to support the WebReady feature in v0.25.

You will be pleased to learn that we're developing a Jenkins build server for Exiv2. One of the challenges of Exiv2 is the size of the build/test matrix. Having a machine dedicated to building in response to commits will significantly improve our day-to-day build/test coverage. I purchased a Mac-Mini which runs the Virtual Machines running Windows and Linux in addition to the being a native Mac. I only acquired the machine 5 weeks ago and it's work in progress at the moment. http://exiv2.dyndns.org:8080

Hi Robin,

sorry that I didn't make it clear. CMake already failed in my case with the following error

CMake Error at src/CMakeLists.txt:191 (ADD_LIBRARY):
  Cannot find source file:

    svn_version.h

You were also right, that there is some special handling in the main CMakeLists file and in the .cpp regarding this file for msvc. However, the src/CmakeLists.txt always tries to include the svn_version.h file. I wonder how this could work in your case. Im using 3358, and my error is confirmed by the repository at http://dev.exiv2.org/projects/exiv2/repository/show/trunk/src where there is no svn_version.h file. Did you maybe use a non-clean source directory?

Anyway, with the small change, similar to the other places I fixed that place. Appending you find the patch. With that, I was able to compile to make an in-source build using VS 2012-x64. Sadly in-source, but thats another story you already know...

Thanks
Daniel

Thank You, Daniel. Yes - you are 100% correct. I've submitted your patch r3364. Thank You for working on this - and thanks for pushing to get to the bottom of this. I'm going to mark this "Resolved".

The MSVC build/test has been rather badly broken r3355 .. r3358. My submission r3359 should restore stability.

I've recruited a new build engineer Nehal Wani and hope he'll be able to spend more time on our CMake support next year. As you know, there are many things to deal with in a software project and limited resources and skills. So, while I regret that our CMake support is weak, I try my best to keep everything moving forward. When we have the Jenkins build server fully operational, perhaps with 2 build engineers on the project, we'll can improve our CMake support.

You are right to be suspicious that a dirty build tree could contain a version of svn_version.h from an earlier ./configure build. The Jenkins build does a "make distclean" on every build. At the moment, we haven't added the code for Jenkins to build using CMake - however we intend to do so.

Thank You once more for your contribution to Exiv2.