Bug #845
CMake compilation issue on MacOS-X
100%
Description
Building from the trunk (svn:2864) on MacOSX
$ sw_vers
ProductName: Mac OS X
ProductVersion: 10.7.4
BuildVersion: 11E53
$ gcc --version
i686-apple-darwin11-llvm-gcc-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00)
...
$ cd ~/gnu/exiv2/test.build
$ mkdir build
$ cd build
$ cmake ..
$ make
...
[ 16%] Built target xmp
[ 17%] Building CXX object src/CMakeFiles/exiv2lib.dir/image.cpp.o
In file included from /Users/rmills/gnu/exiv2/test.build/src/image.cpp:63:
/Users/rmills/gnu/exiv2/test.build/src/matroskavideo.hpp:104: error: ‘uint’ does not name a type
make2: * [src/CMakeFiles/exiv2lib.dir/image.cpp.o] Error 1
make1: [src/CMakeFiles/exiv2lib.dir/all] Error 2
make: ** [all] Error 2
$
I've changed uint findBlockSize(byte b); to uint32_t findBlockSize(byte b); in the following files:
$ svn status -q
M src/matroskavideo.cpp
M src/matroskavideo.hpp
$ sw_vers
ProductName: Mac OS X
ProductVersion: 10.7.4
BuildVersion: 11E53
527 rmills@rmills-imac:~/gnu/exiv2/test.build $ gcc --version
i686-apple-darwin11-llvm-gcc-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00)
Copyright (C) 2007 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$
My inspection, I don't expect side effects from my fix. I've built this on Mac and Windows(MSVC) and Linux without issue.
I've submitted this (svn: 2865)
Abhinav:
Can you "bless this" by updating this bug to "closed".
Associated revisions
History
Updated by Abhinav Badola about 9 years ago
- Status changed from Feedback to Closed
- % Done changed from 90 to 100
Fix submitted: Issue #845. See: http://dev.exiv2.org/issues/845