Project

General

Profile

Patch #819

Recognize Pentax MakerNote in DNGPrivateData

Added by Jonathan Kollasch over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Category:
exif
Target version:
Start date:
04 Apr 2012
Due date:
% Done:

100%

Estimated time:

Description

This patch has the basics needed to recognize the Pentax MakerNote in a Pentax native DNG.
(Tested for reading only.)


Files

diff (9.38 KB) diff patch Jonathan Kollasch, 04 Apr 2012 09:17

Associated revisions

Revision 2696 (diff)
Added by Andreas Huggel over 9 years ago

#819: Applied Pentax DNG makernote patch from Jonathan Kollasch.

Revision 2697 (diff)
Added by Andreas Huggel over 9 years ago

#819: Changed PentaxId to PentaxDngId and some formatting tweaks.

Revision 2698 (diff)
Added by Andreas Huggel over 9 years ago

#819: Fixed PentaxDng offsets so that they are relative to the beginning of the makernote, added support for the PentaxDng preview image.

Revision 2699 (diff)
Added by Andreas Huggel over 9 years ago

#819: Fixed write support.

Revision 2711 (diff)
Added by Andreas Huggel over 9 years ago

#819: Updated easy-access functions with the new PentaxDng tags.

Revision 2744 (diff)
Added by Andreas Huggel over 9 years ago

#819: Added the PentaxDng Preview image to the tags potentially stripped when encoding the Exif metadata for JPEG (related to #820).

History

#1

Updated by Andreas Huggel over 9 years ago

  • Category set to exif

Thanks for the patch, Jonathan. I just came back from a vacation and am still catching up with everything. From a quick look at the patch, this looks good, I'll spend more time as soon as possible.

In the meantime, could you please attach (or send me directly) an image with such a makernote?

Andreas

#3

Updated by Jonathan Kollasch over 9 years ago

Bug #758 and #759 also have Pentax DNG files attached (from Pentax K-x cameras).

#4

Updated by Andreas Huggel over 9 years ago

Checked-in the patch and made a small change to actually decode the makernote tags using group PentaxDng rather than Pentax (r2697).
What remains is to update preview.cpp so that the thumbnail image in the makernote is recognized again and test writing such a makernote.

#5

Updated by Andreas Huggel over 9 years ago

  • Assignee set to Andreas Huggel
  • Target version set to 0.23
  • % Done changed from 0 to 100
#6

Updated by Andreas Huggel over 9 years ago

  • Status changed from New to Resolved
#7

Updated by Andreas Huggel over 9 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF