Exiv2

After two weeks of waiting: Can someone please accept this issue. I tried but I failed.

If I run the debug version of exiv2.exe (i.e. with undefined SUPPRESS_WARNINGS) I get a strange error on the original PNG file imagemagick.png which like a strange bug.

C:\temp>exiv2.exe -pc imagemagick.png
Error: Directory NikonPreview with 512 entries considered invalid; not read.

OK, thanks for looking into this.

By the way, SUPPRESS_WARNINGS is kind of misleading here. If it is undefined, I get an error and exiv2 aborts. If it is defined, there is neither a warning nor a error. I think it is better if SUPPRESS_WARNINGS only suppresses warnings and not changes the error / exception behaviour.

The differentiation between "Warning" and "Error" messages is subjective and I have no well-defined criteria for it (suggestions welcome). Both are equally affected by the SUPPRESS_WARNINGS flag. Exceptions are different. SUPPRESS_WARNINGS should not modify the program flow, in particular it should not affect exceptions. It's a bug if it does, but the code for the error you highlighted looks ok, it doesn't explain your observation, will also check in more detail later.

        // Sanity check with an "unreasonably" large number
        if (n > 256) {
#ifndef SUPPRESS_WARNINGS
            EXV_ERROR << "Directory " << groupName(object->group()) << " with " 
                      << n << " entries considered invalid; not read.\n";
#endif
            return;
        }

Yes, r2634 solves the primary problem with the PNG comment on Windows using MS Visual Studio C++ 2010 SP1 Express Edition.

I checked in Debugger with Visual Leak Detector Version 2.2 (if compiled with defined SUPPRESS_WARNINGS) and could not detect any memory holes.

The command that aborts (if compiled with undefined SUPPRESS_WARNINGS) is (taken from above):
C:\temp>exiv2.exe -pc imagemagick.png
Error: Directory NikonPreview with 512 entries considered invalid; not read.
This error still occurs with the fix r2634.

C:\temp>exiv2.exe -pc imagemagick.png
Error: Directory NikonPreview with 512 entries considered invalid; not read.
This error still occurs with the fix r2634.

Are you sure it aborts, i.e., throws an exception or crashes? Here all I get is that error message, but that doesn't change the program flow (see the code snippet above). I can't reproduce any exception or crash, if you really observe something like that, can you please try to trace where it comes from? (btw the -q option will turn it off)

Andreas

Sorry for confusion. It is not a program exception or crash but rather a regular program termination with an error message.

With undefined SUPPRESS_WARNINGS:
C:\temp>exiv2.exe -pc imagemagick.png
Error: Directory NikonPreview with 512 entries considered invalid; not read.

With defined SUPPRESS_WARNINGS:
C:\temp>exiv2 -pc imagemagick.png
PNG

It is just about the different program flow. If SUPPRESS_WARNINGS is not defined I get an error message rather than the expected PNG comment. If SUPPRESS_WARNINGS is defined, the program output is as expected.