Project

General

Profile

Bug #645

Conversion from XMP sidecar leaks XMP-SDK exception. (digiKam bug 204042)

Added by Andreas Huggel over 12 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
xmp
Target version:
0.19
Start date:
17 Aug 2009
Due date:
% Done:

100%

Estimated time:

Description

The conversion from XMP (typically when reading an XMP sidecar file) with invalid (non ISO 8601) timestamps leaks an XMP-SDK exception. The XMP-SDK function SXMPUtils::ConvertToDate throws an XMP_Error if the conversion fails. (Check other XMP-SDK functions as well.)

The Exiv2 library must catch such exceptions and should do something useful anyway, or, if not possible, at least translate them to Exiv2 exceptions.

Reported by François Tissandier as digiKam bug 204042

Files

exiv2-parse-date.patch (670 Bytes) exiv2-parse-date.patch Vladimir Nadvornik, 15 Sep 2009 13:14
exiv2-parse-date2.patch (691 Bytes) exiv2-parse-date2.patch Vladimir Nadvornik, 15 Sep 2009 13:39

Associated revisions

Revision 1899 (diff)
Added by Andreas Huggel about 12 years ago

#645: Catch XMP-SDK exception from date conversion. (Vladimir Nadvornik)

Revision 1900 (diff)
Added by Andreas Huggel about 12 years ago

#645: Added check for empty GPS coordinate value to prevent out-of-range exception.

History

#1

Updated by Vladimir Nadvornik about 12 years ago

The attached patch should fix it.

#2

Updated by Vladimir Nadvornik about 12 years ago

And this is the correct version of the patch ;)

#3

Updated by Andreas Huggel about 12 years ago

  • Status changed from New to Resolved
  • Target version set to 0.19
  • % Done changed from 0 to 100

Thanks Vladimir.

With the additional check in r1900 the sample XMP from the original digiKam bug now works.

#4

Updated by Andreas Huggel almost 12 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF