Project

General

Profile

Feature #1060

ISO speed readout & low-light cameras

Added by Robin Mills over 6 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Thomas Beutlich
Category:
metadata
Target version:
0.26
Start date:
22 Apr 2015
Due date:
% Done:

100%

Estimated time:
10.00 h

Description

Discussion: http://dev.exiv2.org/boards/3/topics/2027

Files

src__easyaccess_cpp.diff (3.39 KB) src__easyaccess_cpp.diff Diff for src/easyaccess.cpp Spex Duplex, 10 May 2015 07:58
test__Makefile.diff (406 Bytes) test__Makefile.diff Diff for test/Makefile Spex Duplex, 10 May 2015 07:58
iso65k-test.sh (7.12 KB) iso65k-test.sh test/iso65k-test.sh Spex Duplex, 10 May 2015 07:58
iso65k-test.out (6.1 KB) iso65k-test.out test/data/iso65k-test.out Spex Duplex, 10 May 2015 07:58
T1060.patch (4.63 KB) T1060.patch Thomas Beutlich, 24 Aug 2016 19:25

Associated revisions

Revision 4451 (diff)
Added by Robin Mills about 5 years ago

#1060 Thank you to Thomas B for working on this and providing the patch.

Revision 4452 (diff)
Added by Robin Mills about 5 years ago

#1060 Resequenced tests in alphabetic order.

History

#1

Updated by Spex Duplex over 6 years ago

Ok, that took a bit longer than I wanted, because these things are lying around for about 2 weeks already. Anyway ...

Added a patch for easyaccess.cpp as well as test related files + Makefile patch.

Note: code quality is probably not up to par for easyaccess.cpp, used while + break to avoid nesting, for example.

#2

Updated by Thomas Beutlich about 5 years ago

Attached is a slightly updated patch for easyaccess.cpp and test/Makefile.

#3

Updated by Robin Mills about 5 years ago

  • Status changed from New to Assigned
  • Assignee set to Thomas Beutlich
  • % Done changed from 0 to 80
  • Estimated time set to 4.00 h

Thomas

I've submitted you patch and test script. Thank you doing this work. I don't know anything about the code you have modified here, however it builds and passes the test suite with the autotools and CMake. Can I ask you to update the "Estimated time" to reflect the effort that this took. If you believe this is complete, please mark it "Closed".

#4

Updated by Thomas Beutlich about 5 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 80 to 100
  • Estimated time changed from 4.00 h to 10.00 h

Well, the patch was developed to Spex Duplex. Estimated work: 10h.

#5

Updated by Robin Mills about 5 years ago

Ah, yes. You've taken his code and made it into a patch. Thanks to you both for working on this. Almost there with v0.26, thank goodness.

Also available in: Atom PDF