Patch #1044
Parse TIFF PageNumber
100%
Description
http://dev.exiv2.org/boards/3/topics/1929
Thomas, can you please review this, discuss it with Mario and give me your assessment. And of course if you have a patch, please attach it to this issue. As Mario has been kind enough to provide a test file, we should also consider updating the test suite to take advantage of that file.
Files
History
Updated by Thomas Beutlich over 6 years ago
- File T1044.patch T1044.patch added
Yes, patch works as expected. I could not apply the provided Exif.Image.PageNumber.patch but needed to manually patch it. New patch T1044.patch should hopefully work.
Thank you, Mario and Robin!
Updated by Mario Emmenlauer over 6 years ago
Thanks for the great (and very fast) work, Thomas and Robin! Two thumbs up!
Updated by Robin Mills over 6 years ago
Submitted r3632. Thank You, Mario for reporting this and providing the patch. Thank You, Thomas for validating the patch.
Updated by Thomas Beutlich over 6 years ago
- Assignee changed from Thomas Beutlich to Robin Mills
Back to Robin for the optional test case. I have no idea how to do it since I do not run the test suite.
Updated by Robin Mills over 6 years ago
Mario
Is there any reason why we cannot copy your test file into our test suite (for example copyright). If you're OK with this, I'll add your file to the test suite tomorrow as a regression detector.
Updated by Mario Emmenlauer over 6 years ago
Dear Robin and all, yes I agree, please use the file I sent in your test collection and anywhere else in development where you see fit! No copyright restrictions apply (as long as the predominant use is to aid in your development).
Thanks again and all the best!
Updated by Robin Mills over 6 years ago
- Status changed from Assigned to Resolved
Thanks Mario. Test suite updated: r3640. Good teamwork. Thanks Everybody.
#1044. Thank you Mario for reporting this an providing a patch. Thank You for Thomas for validating this fix.