Project

General

Profile

Bug #1225

Nikon BarometerInfo

Added by Juergen Rose about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Robin Mills
Category:
makernote
Target version:
0.26
Start date:
09 Sep 2016
Due date:
11 Sep 2016
% Done:

100%

Estimated time:
0.00 h

Description

exiftools provides more information than exiv2 for Nikon photos, e.g. BarometerInfo with Altitude, compare http://dev.exiv2.org/boards/3/topics/2731?r=2734#message-2734. I would appreciate very much if these additional information would be also available with libexif2.

Associated revisions

Revision 4480 (diff)
Added by Robin Mills about 5 years ago

#1225 Fix

Revision 4484 (diff)
Added by Robin Mills about 5 years ago

#1225 Correction to r4480 to respect the endianness of file and platform

History

#1

Updated by Robin Mills about 5 years ago

  • Subject changed from Access additional MakerNotes for Nikon, e.g. BarometerInfo (Altitude) to Nikon BarometerInfo
  • Target version changed from 0.26 to 1.0
#2

Updated by Robin Mills about 5 years ago

  • Assignee deleted (Robin Mills)
#3

Updated by Robin Mills about 5 years ago

  • Status changed from New to Resolved
  • Assignee set to Niels Kristian Bech Jensen
  • Target version changed from 1.0 to 0.26
  • % Done changed from 0 to 80
  • Estimated time set to 2.00 h

Fix submitted r4480.

593 rmills@rmillsmbp:~/gnu/exiv2/trunk $ exiv2 -pa --grep bar/i http://dev.exiv2.org/attachments/download/1060/25850685556_622312410d_o.jpg
Exif.Nikon3.BarometerInfo                    Undefined  12  1583
594 rmills@rmillsmbp:~/gnu/exiv2/trunk $
I'm assigning this to Niels for code review.

http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Nikon.html#BarometerInfo

I've extracted the metadata from your test image and added it to our test suite.

#4

Updated by Niels Kristian Bech Jensen about 5 years ago

  • Due date set to 11 Sep 2016
  • % Done changed from 80 to 100
  • Estimated time changed from 2.00 h to 0.00 h

Except for the small whitespace fix (r4483) the code seems to be correct.

Best regards,
Niels Kristian Bech Jensen

#5

Updated by Robin Mills about 5 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Niels Kristian Bech Jensen to Robin Mills

Thank You, Niels for reviewing this. The space typo was totally my error. I'm going to close this.

Another tiny step closer to v0.26. Hope to be feature complete this week, however I've been saying that since early August!

Also available in: Atom PDF