Bug #586: ValueType<T> constructor makes assumptions of the endianness of the machine - Exiv2

Bug #586

ValueType<T> constructor makes assumptions of the endianness of the machine

Added by Andreas Huggel almost 13 years ago. Updated almost 13 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

metadata

Target version:

0.18

Start date:

Due date:

% Done:

90%

Estimated time:

Description

If I use the following code on Intel (little endian) machines:

exifData["Exif.Image.XResolution"] = Exiv2::ShortValue(37);

I get an expected resolution of 37 in the final image. However on
PowerPC (big endian) the bytes are swapped and the resolution value is
a lot bigger.

Reported by Dimitri in http://uk.groups.yahoo.com/group/exiv2/message/1449

Additional information:

The idea is that Exiv2 doesn't need to know the endianness of the machine in the first place - only that used in the TIFF data. This case violates this principle and makes an assumption for the endianness of the machine.

History

Updated by Dimitri Schoolwerth almost 13 years ago

Fixed by revision 1695, the above code now gives the same result on both little and big endian machines. There's no need anymore to always pass the native endianness as a parameter. Thanks!