Exiv2

Ben: I'm puzzled by this patch. There are two different subjects being mixed together:

1) Adding new stubs for printStructure for currently unsupported image types.
Is there something wrong with the existing behaviour of throwing an exception for unsupported file formats?
This feature was initially added for JPEG and PNG (by Tuan in GSoC 2013 in his version of exifprint.cpp
I moved it to $ exiv2 -pS foo.jpg and then added TIFF support in v0.25
I added more formats and the recursive version: $ exiv2 -pR foo.jpg in v0.26

2 Adding LocalNetFileIo into BasicIo
I would like to see this logged as a different issue.
Did you intend to put this into the patch?
I'm willing to split the patch and open and issue about LocalNetFileIo

1) Is there something wrong with the exceptions; not from my point of view, but at the time i was asked to add them in by a client.There was a misunderstanding about what printStructure really did. I submitted it as requested by them. I have added on their end some changes that i need to fold back here. I guess the stub ones could be removed at this point in time. I may redo this soon to remove them and add the new full
implementations i've added on their end.

2) I have a separate class for blockfileio with uri for paths i did for them i'll hopefully be able to submit soon. I had to use a uri style entry (does not use a real uri since i pass it the real full path) to hook it up like http io does.

I'm lost. Am I to submit ps.diff with the Format::printStructure() methods AND LocalNetFileIo class, or will you provide a new patch?

I'll make a new patch for this issue to supersede the two previous ones. I think i leaked some wrong code in that first patch that was from my first attempt at using remoteio. I need to review this once i've had enough coffee and breakfast. :)

Very good. Can you make the patch with the command:

svn diff

Sure, does it accept regular "diff -u" files?

The correct format is like this:

514 rmills@rmillsmbp:~/gnu/exiv2/trunk $ svn diff .
Index: src/version.cpp
===================================================================
--- src/version.cpp    (revision 4705)
+++ src/version.cpp    (working copy)
@@ -2,7 +2,7 @@
 /*
  * Copyright (C) 2004-2015 Andreas Huggel <ahuggel@gmx.net>
  *
- * This program is part of the Exiv2 distribution.
+ * This program is part of the Exiv2 distribution you know.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
515 rmills@rmillsmbp:~/gnu/exiv2/trunk $ 

Index: src/tgaimage.cpp
===================================================================
diff --git a/trunk/src/tgaimage.cpp b/trunk/src/tgaimage.cpp
--- a/trunk/src/tgaimage.cpp    (revision 4698)
+++ b/trunk/src/tgaimage.cpp    (working copy)
@@ -74,6 +74,16 @@
         throw(Error(32, "Image comment", "TGA"));
     }

+    void TgaImage::printStructure(std::ostream& out, PrintStructureOption option, int depth) {
+        if (io_->open() != 0) throw Error(9, io_->path(), strError());
+        IoCloser closer(*io_);

Index: src/tgaimage.cpp
===================================================================
--- a/trunk/src/tgaimage.cpp    (revision 4698)
+++ b/trunk/src/tgaimage.cpp    (working copy)

Index: src/tgaimage.cpp
===================================================================
--- src/tgaimage.cpp    (revision 4698)
+++ src/tgaimage.cpp    (working copy)

1. Remove the diff --git a/trunk/src/tgaimage.cpp b/trunk/src/tgaimage.cpp command
2. Edit a/trunk/src/tgaimage.cpp into src/tgaimage.cpp
3. Edit b/trunk/src/tgaimage.cpp into src/tgaimage.cpp

I could write a little script to do this. However, I don't know what are a and b? Does git always do this, or does 'a' and 'b' mean something on your local file system.

I don't mind doing this in a little patch (to modify one or two files). However for a patch which changes many files (such as ps.diff), there are 31 files in the patch and it's very tedious to edit all of this manually.

Do you want me to review and submit. Or only to review this patch?

At least a quick review, if you want to submit sure, else i can do it after that.

Fine. I'll do that after dinner when Alison goes to the Scottish Country Dancing. I'll also hope finish to my work on the temporary file issue this evening.