Exiv2

Please provide a sample image. It will be investigated and fixed in v0.27. I'm at the end of the v0.26 development cycle and very reluctant to take on anything new at this time.

I understand that you consider this is to be a high priority matter. I disagree. The jp2image.cpp code mostly dates from 2008 and, to my knowledge, this interoperability issue has never been reported. For sure, I have neither sufficient time nor energy to delay v0.26 to investigate this matter.

Hello,

thanks for your quick reply.
Attached please find such a test.jp2 image.

Phil Harvey stated also that after removing the 6 byte header the remaining data are a proper Exif block.

And attached find also the verbose output of Exiftool when it tries to read metadata.
Maybe it helps a little bit.

Best regards
Herb

Herb

Thank you for providing a test file. I will submit a fix for this tomorrow.

I have never studied the JP2 image format and I'm very surprised to see that we don't have such an image in our test suite. When I dump your file (with the enclosed dmpf.cpp code), I see:

  0x50     80: .uuidJpgTiffExif  ->  1c  u  u  i  d  J  p  g  T  i  f  f  E  x  i  f
  0x60     96: ->JP2Exif..II*..  ->   -  >  J  P  2  E  x  i  f 00 00  I  I  * 00 08

667 rmills@rmillsmbp:~/gnu/exiv2/trunk $ cp test/data/Reagan.jpg .
668 rmills@rmillsmbp:~/gnu/exiv2/trunk $ convert Reagan.jpg Reagan.jp2
669 rmills@rmillsmbp:~/gnu/exiv2/trunk $ exiftool -tagsfromfile Reagan.jpg -exif:all Reagan.jp2
    1 image files updated
670 rmills@rmillsmbp:~/gnu/exiv2/trunk $ dmpf Reagan.jp2 | grep -B 3 -A 3 uuid
0x7fb0  32688: ...........(.c..  ->  e7 8b 03 0c 2e c7 c5 b7 f7 80 05  ( ad  c 9e a4
0x7fc0  32704: .t..!e.....0...   ->  0f  t a4 a2  !  e 09 d9 12 ff   00  0 0c d5 d7
0x7fd0  32720: .i....@..d.D....  ->  09  i ed 02 f3 f4  @ ca 1f  d cc  D 14 ff d9 00
0x7fe0  32736: ..>uuidJpgTiffEx  ->  00 05  >  u  u  i  d  J  p  g  T  i  f  f  E  x
0x7ff0  32752: if->JP2MM.*.....  ->   i  f  -  >  J  P  2  M  M 00  * 00 00 00 08 00
0x8000  32768: ................  ->  0d 01 0e 00 02 00 00 01 93 00 00 00 aa 01 0f 00
0x8010  32784: ........>.......  ->  02 00 00 00 12 00 00 02  > 01 10 00 02 00 00 00
671 rmills@rmillsmbp:~/gnu/exiv2/trunk $ 

I believe the 6 bytes Exif\0\0 should not be there.

However, I've copied the metadata from Reagan.jpg to Reagan.jp2 using ExifTool and based on this discussion: http://u88.n24.queensu.ca/exiftool/forum/index.php?topic=5696.0

I would really like a "honest" JPEG2000 file that has never been touched by Exiv2 or ExifTool. Preview on the Mac can export JPEG2000 however it remove the metadata. My Adobe Tools (PS Elements 12 and LR5) do not support JPEG 2000. Can you provide a small JP2 file that I can add to the test suite?

My implementation of the fix understands and silently forgives the erroneous Exif\0\0 bytes when it reads such a file. When it writes a JP2 does not write Exif\0\0. So the fix is forgives sins past and fixes files when they are rewritten.

For exiv2 v0.25, I added the option -pS to print the structure of an image. For exiv2 v0.26, I added the option -pR to recursively print the structure of an image. By recursive, I mean that the print will dump image structures embedded in other structures. This is particularly useful in this case as Exif metadata is usually encoded as a TIFF structure. Both options -pS and -pR are implemented by the API Image::printStructure().

For exiv2 v0.26, I have added support for ICC profiles. I'd like to support printStructure() and ICC profiles in src/jp2image.cpp. So, although I have the fix for your issue ready, I'd like to add these additional features. More importantly, I'd like to add test files to our test suite to ensure these fixes are monitored.

This issue will be fixed and submitted to the trunk tomorrow (2016-10-12). I would really appreciate a couple of small (50k or so) JPEG 2000 files. I'd be great for those test files to have embedded Exif/IPTC/XMP/ICC metadata. I hope you have a copy of PhotoShop Creative Suite with which to create those test files. Alternatively, you could ask our good friend Phil to help us out with test data.

r4619. Work in progress. Hopefully Herb (or Phil) can provide more test files.

Hello,

thanks for all your investigations.

You asked for test images. But I regret, I do not have many *.jp2 images.
Background: I work on a small GUI that will display and/or modify metadata via Exiftool. I found ShowFoto and hoped to be able to create e.g. some *.jp2 images for testing with my GUI. So I came to this problem.

But nevertheless I have 2 *.jp2 images, which I found somewhere in the www... I do not remember where I found it. I hope it helps

Thanks again and Best regards
Herb

Herb

Thanks for the files. I don't think there is Exif/IPTC/XML/ICC data embedded in those files. I had an unsuccessful Google for suitable files yesterday. I have not been able to find the specification for JPEG2000. Curiously exiftool does not write ICC profiles in JP2 files. However I submitted the code update because I respect and trust Phil!

Here's what I've done about this:

1) I submitted the code and the test file Reagan.jp2 r4619
2) I have updated our test harness to examine that file on every commit and every nightly build on every platform. r4622
3) I hope to recruit a student in 2017 to work on our raw image support and test (#992).
4) I've opened a new issue (#1243) for v0.27 to implement jp2image::printStructure() to support options: -pX | -pS | -pC, -pR

I'm closing this issue as I believe I've dealt with your immediate concern. The follow-on matters involving printStructure() will be handled in v0.27 under #1243.

Thank You for bringing this to my attention. Thank You for using Exiv2. Good Luck with your project.

Hello,

thanks for your investigations and the correction.

Looking for further *.jp2 images I found one on an (rarely useed) USB-stick that also contains an icc-profile.

Best regards
Herb