Bug #1200
Support for Sigma 17-70mm F2.8-4 DC Macro OS HSM | C
Start date:
09 Aug 2016
Due date:
% Done:
100%
Estimated time:
Description
While calibrating this lens for LensFun I noticed that Exif.Photo.LensModel returns nothing:
exiv2 -PEkt -g Exif.Photo.LensModel -g Exif.Photo.FocalLength -g Exif.Photo.FNumber DSC_2985.NEF Exif.Photo.FNumber F4 Exif.Photo.FocalLength 70.0 mm Exif.Photo.FocalLengthIn35mmFilm 105.0 mm
However the Exif seems OK:
exiftool DSC_2985.NEF |grep -i lens Lens Type : G VR Lens : 17-70mm f/2.8-4 Lens Data Version : 0204 Lens ID Number : 142 Lens F Stops : 5.00 Lens ID : Sigma 17-70mm F2.8-4 DC Macro OS HSM | C Lens : 17-70mm f/2.8-4 G VR exiv2 -pt DSC_2985.NEF |grep -i lens Exif.Nikon3.LensType Byte 1 D G VR Exif.Nikon3.Lens Rational 4 17-70mm F2.8-4 Exif.Nikon3.LensFStops Undefined 4 5 Exif.NikonLd3.LensIDNumber Byte 1 Sigma 17-70mm F2.8-4 DC MACRO OS HSM Contemporary Exif.NikonLd3.LensFStops Byte 1 F5.0
I'm not sure if this is normal or not, or if there is really anything to do on Exiv2 side, but I guess that you experts will know.
I attached a file made with this lens on a Nikon D5500.
Lens maker URL: http://www.sigmaphoto.com/17-70mm-f28-4-dc-macro-os-hsm-c
Files
Related issues
Associated revisions
History
Updated by Robin Mills over 5 years ago
- Status changed from New to Closed
- Assignee set to Robin Mills
- Target version set to 0.26
- % Done changed from 0 to 100
I think this is fixed on the trunk:
Exif.Nikon3.LensType Byte 1 D G VR Exif.Nikon3.Lens Rational 4 17-70mm F2.8-4 Exif.Nikon3.LensFStops Undefined 4 5 Exif.NikonLd3.LensIDNumber Byte 1 Sigma 17-70mm F2.8-4 DC MACRO OS HSM | C Exif.NikonLd3.LensFStops Byte 1 F5.0 609 rmills@rmillsmbp:/usr/local/bin $ exiv2 -pv --grep lens/i ~/Downloads/DSC_2985.NEF 0x0083 Nikon3 LensType Byte 1 14 0x0084 Nikon3 Lens Rational 4 170/10 700/10 28/10 40/10 0x008b Nikon3 LensFStops Undefined 4 60 1 12 0 0x000c NikonLd3 LensIDNumber Byte 1 142 0x000d NikonLd3 LensFStops Byte 1 60The fix is in line 2108 of nikonmn.cpp
629 rmills@rmillsmbp:~/gnu/exiv2/trunk/src $ nl -b a nikonmn.cpp | grep -e "17-70mm F2.8-4 DC MACRO OS HSM"
2108 {0x8E,0x3C,0x2B,0x5C,0x24,0x30,0x4B,0x0E,0x00,0x00,0x00, "Sigma", "", "17-70mm F2.8-4 DC MACRO OS HSM | C"},
630 rmills@rmillsmbp:~/gnu/exiv2/trunk/src $ This was submitted by Niels in r4226:630 rmills@rmillsmbp:~/gnu/exiv2/trunk/src $ svn blame nikonmn.cpp | grep -e "17-70mm F2.8-4 DC MACRO OS HSM"
4226 nkbj {0x8E,0x3C,0x2B,0x5C,0x24,0x30,0x4B,0x0E,0x00,0x00,0x00, "Sigma", "", "17-70mm F2.8-4 DC MACRO OS HSM | C"},
631 rmills@rmillsmbp:~/gnu/exiv2/trunk/src $ Here's the log entry:634 rmills@rmillsmbp:~/gnu/exiv2/trunk/src $ svn log --revision 4226 --verbose ------------------------------------------------------------------------ r4226 | nkbj | 2016-03-12 04:32:50 +0000 (Sat, 12 Mar 2016) | 1 line Changed paths: M /trunk/src/canonmn.cpp M /trunk/src/nikonmn.cpp M /trunk/src/pentaxmn.cpp Agreed with Phil Harvey (author of ExifTool) upon a nomenclature for Sigma lens families. ------------------------------------------------------------------------ 635 rmills@rmillsmbp:~/gnu/exiv2/trunk/src $
#1200 and #1034. Adding support for ~/.exiv2 for Nikon Cameras.