Project

General

Profile

Bug #1155

Wrong or just Sigma lens lens info with Pentax K-3

Added by Hannu Vuolasaho almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Robin Mills
Category:
lens
Target version:
0.26
Start date:
17 Jan 2016
Due date:
% Done:

100%

Estimated time:
3.00 h

Description

I tested three different sigma lenses and none gave right data.

DNGs avaiable:
https://drive.google.com/folderview?id=0B_YBWcZLryjpM2tWT1FkdDNNYkE&usp=sharing

Files

log.txt (2.25 KB) log.txt exiv2 -pa sigma*|grep Lens Hannu Vuolasaho, 17 Jan 2016 21:22
pentax_istdl_sigma_10-20_1colon4-5.6_DC.exv (30.4 KB) pentax_istdl_sigma_10-20_1colon4-5.6_DC.exv istdl 10-20 Hannu Vuolasaho, 20 Jan 2016 12:34
pentax_istdl_sigma_APO_DG_70-300_1colon4-5.6.exv (20.9 KB) pentax_istdl_sigma_APO_DG_70-300_1colon4-5.6.exv istdl 70-300 Hannu Vuolasaho, 20 Jan 2016 12:34
pentax_istdl_sigma_zoom_70-210_1colon4-5.6_UC-II.exv (31.4 KB) pentax_istdl_sigma_zoom_70-210_1colon4-5.6_UC-II.exv istdl 70-210 Hannu Vuolasaho, 20 Jan 2016 12:34
pentax_k100d_sigma_10-20_10-20_1colon4-5.6_DC.exv (33.8 KB) pentax_k100d_sigma_10-20_10-20_1colon4-5.6_DC.exv k100 10-20 Hannu Vuolasaho, 20 Jan 2016 12:34
pentax_k100d_sigma_APO_DG_70-300_1colon4-5.6.exv (32.3 KB) pentax_k100d_sigma_APO_DG_70-300_1colon4-5.6.exv k100 70-300 Hannu Vuolasaho, 20 Jan 2016 12:34
pentax_k100d_sigma_zoom_70-210_1colon4-5.6_UC-II.exv (33.8 KB) pentax_k100d_sigma_zoom_70-210_1colon4-5.6_UC-II.exv k100 70-210 Hannu Vuolasaho, 20 Jan 2016 12:34

Associated revisions

Revision 4190 (diff)
Added by Robin Mills almost 6 years ago

#1155. Fix summitted.

Revision 4191 (diff)
Added by Robin Mills almost 6 years ago

#1155. Fixes submitted. Thank You, Hannu for reporting this and providing test data.

History

#1

Updated by Robin Mills almost 6 years ago

  • Category set to lens
  • Status changed from New to Assigned
  • Assignee set to Robin Mills
  • Target version set to 0.26

Hannu

Are the DNGs in the drop box? I see some little JPGs and a log file. Am I doing something wrong on Dropbox?

#2

Updated by Robin Mills almost 6 years ago

I've got your DNGs. I'll look at them on Monday.

#3

Updated by Robin Mills almost 6 years ago

Fix submitted. r4190. Please test and let me know if you discover lens/camera combinations that don't work correctly (I expect you will). If you discover something wrong, please post the .exv file which you can create with $ exiv2 -ea foo.DNG This is a tiny little JPG that contains a copy of your metadata.

I've extracted the metadata from your DNGs and added them to our test suite as a regression detector.

780 rmills@rmillsmbp:~/gnu/exiv2/trunk $ ls -alt test/data/*1155*
-rw-r--r--+ 1 rmills  staff  19065 18 Jan 07:01 test/data/exiv2-bug1155a.exv
-rw-r--r--+ 1 rmills  staff  19065 18 Jan 07:01 test/data/exiv2-bug1155b.exv
-rw-r--r--+ 1 rmills  staff  19065 18 Jan 07:01 test/data/exiv2-bug1155c.exv
781 rmills@rmillsmbp:~/gnu/exiv2/trunk $
Your DNGs:
782 rmills@rmillsmbp:~/gnu/exiv2/trunk $ ls -alth ~/Downloads/*.DNG
-rw-r--r--@ 1 rmills  staff    33M 17 Jan 23:04 /Users/rmills/Downloads/sigma_zoom_70-210_1colon4-5.6_UC-II.DNG
-rw-r--r--@ 1 rmills  staff    34M 17 Jan 23:04 /Users/rmills/Downloads/sigma_DC_18-50_1colon2.8-4.5_HSM_OS.DNG
-rw-r--r--@ 1 rmills  staff    35M 17 Jan 23:04 /Users/rmills/Downloads/sigma_APO_DG_70-300_1colon4-5.6.DNG
783 rmills@rmillsmbp:~/gnu/exiv2/trunk $
I've extracted the metadata from your DNGs and added them to our test suite as a regression detector.
784 rmills@rmillsmbp:~/gnu/exiv2/trunk $ exiv2 -pa --grep lenstype/i ~/Downloads/*.DNG
/Users/rmills/Downloads/sigma_APO_DG_70-300_1colon4-5.6.DNG  Exif.PentaxDng.LensType  Byte  4  Sigma 70-300mm F4-5.6 Macro
/Users/rmills/Downloads/sigma_DC_18-50_1colon2.8-4.5_HSM_OS.DNG  Exif.PentaxDng.LensType  Byte  4  Sigma 18-50mm F2.8-4.5 HSM OS
/Users/rmills/Downloads/sigma_zoom_70-210_1colon4-5.6_UC-II.DNG  Exif.PentaxDng.LensType  Byte  4  Sigma Zoom 70-210mm F4-5.6 UC-II
785 rmills@rmillsmbp:~/gnu/exiv2/trunk $
And with the .exv files:
785 rmills@rmillsmbp:~/gnu/exiv2/trunk $ exiv2 -pa --grep lenstype/i test/data/*1155*
test/data/exiv2-bug1155a.exv  Exif.PentaxDng.LensType  Byte 4  Sigma 70-300mm F4-5.6 Macro
test/data/exiv2-bug1155b.exv  Exif.PentaxDng.LensType  Byte 4  Sigma 18-50mm F2.8-4.5 HSM OS
test/data/exiv2-bug1155c.exv  Exif.PentaxDng.LensType  Byte 4  Sigma Zoom 70-210mm F4-5.6 UC-II
786 rmills@rmillsmbp:~/gnu/exiv2/trunk $

#4

Updated by Robin Mills almost 6 years ago

  • % Done changed from 0 to 80
  • Estimated time set to 3.00 h
#5

Updated by Hannu Vuolasaho almost 6 years ago

I took my old bodies (K100D and *ist DL) and put those two lenses and both gave wrong lens values with revision 4190 SVN. Also 10-20 was tested which worked correctly with K-3, but not with K100D and *ist DL 18-50

Originals can be found from same URL in google drive. and I attached *exv files. I hope this helps making more general detection of lenses.

#6

Updated by Hannu Vuolasaho almost 6 years ago

Just too hasty submit. 18-50 doesn't work with those so I didn't test it.

#7

Updated by Robin Mills almost 6 years ago

Thanks, Hannu. Lens detection is troublesome. The camera/lens manufacturer should set Exif.Image.LensID uniquely for the lens. They seldom do. So I have to look at other values such as LensInfo, FocalLength and MaxAperture to determine the lens. This can only be done with have suitable test files. Thank You for working with me to get this fixed. I hope to add the necessary code for your test files this evening.

#8

Updated by Robin Mills almost 6 years ago

Fixes submitted: r4191. Thank You, Hannu for reporting this and providing test data. I have added your .exv files to our test suite as a regression detector.

#9

Updated by Robin Mills almost 6 years ago

  • Status changed from Assigned to Closed
#10

Updated by Robin Mills almost 6 years ago

  • % Done changed from 80 to 100

Also available in: Atom PDF