Project

General

Profile

Forums » Forum »

Issue with Sigma 17-70 lens mounted on a canon

Added by Philippe Midol-Monnet over 5 years ago

Hi

The Sigma 17-70mm f/2.8-4 DC Macro OS HSM is not correctly detected. Instead we got Canon EF 500mm f/4L IS.

Therefore I modified canonmn.cpp by adding two lines

line 740: { 143, "Sigma 17-70mm f/2.8-4 DC Macro OS HSM" }, // 1
line 946: { 143, printCsLensByFocalLength },

Now the lens is detected.

Regards

Philippe


Replies (4)

RE: Issue with Sigma 17-70 lens mounted on a canon - Added by Robin Mills over 5 years ago

Thank you, Philippe. I've registered this as #1167 Thanks for the patch, I'll review/test and submit it tomorrow.

RE: Issue with Sigma 17-70 lens mounted on a canon - Added by Robin Mills over 5 years ago

Philippe

Can you provide a test file for this please? I'll extract the metadata from your test file and add it to our test suite. As well as confirming that your patch works, the test suite has a regression detector should your patch break at some time in the future.

Robin

RE: Issue with Sigma 17-70 lens mounted on a canon - Added by Robin Mills over 5 years ago

Thanks, Philippe. I submitted your patches for #1166 and #1167 yesterday. I'll update the test suite tomorrow with the metadata from your test file. Thanks very much for providing this.

    (1-4/4)