Exiv2

Same reply as http://dev.exiv2.org/boards/3/topics/1407 !

Fix it and send me a patch!

Robin

This is the data I got from a picture taken with the Tokina 400mm f5.6 ATX AF on my Pentax *ist DL

jpb@Maple:~/Pictures/exiv2$ exiv2 -pt IMGP4671.PEF | grep -i lens
Exif.Pentax.LensType Byte 2 smc PENTAX-F 35-70mm F3.5-4.5
Exif.Pentax.LensInfo Undefined 36 3 28 0 114 40 212 67 156 131 4 152 65 162 170 120 56 1 81 109 251 255 255 255 0 0 99 4 140 0 0 0 0 0 0 0 0

I am attaching a small IMGP4671jpg
also the line
Exif.Photo.FocalLengthIn35mmFilm Short 1 600.0 mm
this would be correct for the 4oomm lens with a multiplication factor of 1.5

I do not know how to go any farther with this, I could not program to save my life
I hope yhis helps

paul

Paul

Thanks. Niels might convert your information into a patch. If he's not available, I'll deal with this as the weekend. Thanks for sending the test file - that's very helpful.

Robin

Here is a patch. I have added the string "or Tokina Lens" to the LensType tag like ExifTool does. The problem is that Tokina uses the same lens ID number as Pentax does.

The LensInfo tag is currently not decoded in Exiv2 according to comments in pentaxmn.cpp.

Regards,
Niels Kristian

I can see that the Pentax lens list needs to be synchronized with ExifTool. I will work on that.

Regards,
Niels Kristian

So does lensfun
I have a few lens correction info built for them.

A new release of lensfun is close. You should submit any patches ASAP.

Regards,
Niels Kristian

Thank you Niels and Paul for working on this. I've submitted the patch. SVN:2985 I'll update the test suite at the weekend.

Robin

I've reported a bug #884 to handle both top 1411 and 1407. Test suite has been updated: SVN:2987.