Exiv2

Paul

Thanks for bringing this to our attention. I've a quick look in the code, and I believe we have this in the code on the trunk.

C:\gnu.test\exiv2\src>grep -i 4e6 p*.cpp
pentaxmn.cpp: { 0x04e6, "Tamron SP AF 17-50mm F2.8 XR Di II" },

You may be able to build the code and replace the exiv2 shared object in darktable. Or Pascal might give you a private build which includes this update. Or it'll be included in a future version of darktable.

I've checked the change log and this code was only added on 2013-01-03. The patch was provided by exiv2's good friend Sjaak Verdoold. http://dev.exiv2.org/boards/3/topics/1269 and I believe he communicates with another good exiv2 friend Pascal de Bruijn.

Robin

Thanks I'll wait until it filters into Darktable, I am a great believer in Murphy's Law, If I touch it, it will definably break. :)
Paul

changed my mind. Is there any instructions on howto make the changes? I have another lens with different data.

Paul

Take a look in pentaxmn.cpp. You'll see the tables for different cameras, lens and so on. Update appropriately and test your change, then follow this procedure to submit a patch:
http://dev.exiv2.org/projects/exiv2/wiki/How_do_I_request_changes_to_Maker_Notes_for_New_Camera_Models_and_Accessories

There's a discussion about makernotes here:
http://www.exiv2.org/makernote.html

Robin

jpb@Maple:~/Pictures/exiv2$ exiv2 -pt IMGP4630.PEF | grep -i lens
Exif.Pentax.LensType Byte 2 Unknown (0x04e6)
Exif.Pentax.LensInfo Undefined 36 4 230 0 50 40 222 20 67 84 2 14 98 108 106 113 32 2 49 24 3 255 255 255 230 35 85 3 14 32 166 7 99 3 10 0 0

Paul

Thanks. Niels might convert your information into a patch. If he's not available, I'll deal with this as the weekend. Thanks for sending the test file - that's very helpful.

Robin

Do you have a list of lenses on this site that are designed for the Pentax? Besides the Sigma & Tokina I have 7 or 8 Pentax lenses, M Lens, F ,FA, DA.
I would like to check all of them, if any are missing send you the info this week.

Paul

Hi Paul.

We do not have a list take input from users like you. Just send us a jpeg and lens name if exiv2 reports the lens as unknown.

Regards,
Niels Kristian

You are getting off quite lucky today, only one lens from the 9 is incorrect. :))
7 do not show up in the lensfun data
A PENTAX-F 28-80mm F3.5-4.5

Exif.Pentax.LensType Byte 2 PENTAX-F 28-80mm F3.5-4.5 or SIGMA AF 18-125mm F3.5-5.6 DC
Exif.Pentax.LensInfo Undefined 36 3 29 0 82 40 148 85 70 147 6 19 65 73 137 57 56 2 64 74 251 255 255 255 0 0 115 6 18 0 0 0 0 0 0 0 0

Regards
Paul

Hi Paul.

This lens is detected correctly by exiv2. Sigma is using the same lens ID number for the 18-125mm so there is no way to tell them apart.

Seems you have all the work profiling those lenses for lensfun. :)

Regards,
Niels Kristian

thanks Niels
The Tamron lens in now in the Darktable data.
All my lenses are accounted for.
Paul

I've reported a bug #884 to handle both top 1411 and 1407. Test suite has been updated: SVN:2987.