Project

General

Profile

Bug #1363

Tamron SP 70-200mm F/2.8 Di VC USD G2 - Canon mount

Added by Robin Mills 9 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lens
Target version:
Start date:
06 Aug 2018
Due date:
% Done:

100%

Estimated time:
1.00 h

Description

I am just creating lens correction profile for the above lens and the same time I would like to correct its recognition in the exiv2 too.
The below modification was successfully tested with the the Tamron lens but not tested with the affected Canon EF 300mm one.

If you agree, please introduce the below modification:

--- orig/exiv2-trunk/src/canonmn.cpp    2017-03-16 19:13:12.000000000 +0100
+++ exiv2-trunk/src/canonmn.cpp 2018-08-04 15:19:49.217954370 +0200
@@ -1020,7 +1020,8 @@
         { 488, "Canon EF-S 15-85mm f/3.5-5.6 IS USM"                        },
         { 489, "Canon EF 70-300mm f/4-5.6L IS USM"                          },
         { 490, "Canon EF 8-15mm f/4L Fisheye USM"                           },
-        { 491, "Canon EF 300mm f/2.8L IS II USM"                            },
+        { 491, "Canon EF 300mm f/2.8L IS II USM"                            }, // 0
+        { 491, "Tamron SP 70-200mm F/2.8 Di VC USD G2"                      }, // 1
         { 492, "Canon EF 400mm f/2.8L IS II USM"                            },
         { 493, "Canon EF 500mm f/4L IS II USM"                              }, // 0
         { 493, "Canon EF 24-105mm f/4L IS USM"                              }, // 1
@@ -1112,6 +1113,7 @@
         { 248, printCsLensByFocalLength }, // not tested
         { 250, printCsLensByFocalLength }, // not tested
         { 255, printCsLensByFocalLength }, // not tested
+        { 491, printCsLensByFocalLength }, // not tested
         { 493, printCsLensByFocalLength }, // not tested
         { 747, printCsLensByFocalLength }, // not tested
         { 4143,printCsLensByFocalLength }, // not tested

Balázs Dornfeld


Files

IMG_2969.jpg (168 KB) IMG_2969.jpg Robin Mills, 06 Aug 2018 04:49

Related issues

Related to Exiv2 - Bug #1361: Wrongly identified Canon 2x extender as 1.4x extender with Tamron lensClosed22 Jul 2018

Actions

History

#1

Updated by Robin Mills 9 months ago

#2

Updated by Robin Mills 9 months ago

This issue was reported by private email. I discussed the ~/.exiv2 file with Balázs and that's working for him.

Perhaps one day we'll recruit an Engineer to work on our lens recognition code and this will be one of our test files.

#3

Updated by Robin Mills about 2 months ago

  • Status changed from New to Closed
  • Assignee set to Robin Mills
  • % Done changed from 0 to 100
  • Estimated time set to 1.00 h

Also available in: Atom PDF