Project

General

Profile

Patch #1356

Small patch to configure.py

Added by Sridhar Boovaraghavan about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
build
Target version:
Start date:
08 Jun 2018
Due date:
% Done:

100%

Estimated time:
1.00 h

Description

There is a small issue in configure.py when it replaces the GUIDs of the existing projects.

The line olduid=line[start:line.find('}',start)-1]

should be changed to olduid=line[start:line.find('}',start)]

i.e. the -1 should be removed. It was leaving the last GUID character and filling in a new GUID creating an invalid GUID with 33 characters.


Files

TradesmensBBQ.jpg (85.2 KB) TradesmensBBQ.jpg Robin Mills, 08 Jun 2018 07:32

History

#1

Updated by Robin Mills about 1 year ago

  • File TradesmensBBQ.jpg TradesmensBBQ.jpg added
  • Category set to build
  • Status changed from New to Closed
  • Assignee set to Robin Mills
  • Target version set to 0.27
  • % Done changed from 0 to 100
  • Estimated time set to 1.00 h

Sridhar

How nice to hear from you. I hope you and your family and your new house are all doing well. Everything's fine with us.

Thank you for letting me know about this. In fact, the project has taken a new direction concerning Visual Studio and the msvc/ directory (including configure.py) is being removed in v0.27. I've recruited a couple of new contributors who have done very good work indeed over the last year and I'm looking forward to retiring and leaving them to manage Exiv2 into the future. Luis has rewritten our CMake code and wants to kill off msvc/ I've agreed to go along with how he wants things done. He's introduced me to conan and this makes it possible for CMake+Visual Studio to build and link dependencies. I'm sorry to see msvc/ disappear after 10 years - however it's for the best.

We've finished the remodel of our house. Very happy. We had a BBQ for the tradesmen last Sunday. Life is good.

Also available in: Atom PDF