Exiv2

Thanks for these notes. This sounds familiar to me. I dealt with something like this for a user last year in the Canon Maker Notes:

765 rmills@rmillsmbp:~/gnu/exiv2/0.26 $ svn blame src/canonmn.cpp | grep City
  4738 robinwmill     //! canonTimeZoneCity - array of cityID/cityName used by Canon
  4690 robinwmill     extern const TagDetails canonTimeZoneCity[] = {
  4690 robinwmill         TagInfo(0x0002, "TimeZoneCity", N_("Time zone city"), N_("Time zone city"), canonTiId, makerTags, signedLong, 1, EXV_PRINT_TAG(canonTimeZoneCity)),
767 rmills@rmillsmbp:~/gnu/exiv2/0.26 $ $ svn log --revision 4690
------------------------------------------------------------------------
r4690 | robinwmills | 2016-12-02 10:31:10 +0000 (Fri, 02 Dec 2016) | 1 line

#1231  Thank You to Ayke for providing the patch.

765 rmills@rmillsmbp:~/gnu/exiv2/0.26 $ svn blame src/panasonicmn.cpp | grep City
  3357       nkbj         TagInfo(0x006d, "City", N_("City"), N_("City"), panasonicId, makerTags, undefined, -1, printPanasonicText),
  3357       nkbj         TagInfo(0x0080, "City2", N_("City2"), N_("City2"), panasonicId, makerTags, undefined, -1, printPanasonicText),
766 rmills@rmillsmbp:~/gnu/exiv2/0.26 769 rmills@rmillsmbp:~/gnu/exiv2/0.26 $ svn log --revision 3357
------------------------------------------------------------------------
r3357 | nkbj | 2014-09-08 04:57:56 +0100 (Mon, 08 Sep 2014) | 1 line

Fix issues #929 and #972: Improve Panasonic makernotes support. Thanks goes to numerous people for patches and input.
------------------------------------------------------------------------
770 rmills@rmillsmbp:~/gnu/exiv2/0.26 $ 

Robin Mills wrote:

Do you have enough courage to change the code and provide a patch and test files?

Before changing the tag name please read the mentioned ticket 929 (http://dev.exiv2.org/issues/929), especially note #19 and #20.
The problem is that Panasonic is not consistent it the usage of tags, it depends on the model which tags are used for which information. The conses was to use ExifTools nomenclature for the city tags. So the city names are used internally in this notification.

T

I don't know what to do about this and I don't want to get into a lengthy discussion. The code calls a function printPanasonicText(...) to print the value of the tag. That function has access to all the metadata and can print whatever it likes. However if you want the tag 0x006d to say "City" or "Region" based on the camera model, that's considerably more difficult. I'll have to study the code in more detail to know how to make that happen. I'm unwilling to tackle this without test files and a specification of your expected behaviour. I'm rather busy at the moment with the v0.26.1 dot release.

Robin

Hi Robin,

Robin Mills wrote:

I don't know what to do about this

Sorry, if I confused you. I don't want to change the tag name (I want to leave these tag name as there are) .
I just wanted to add a comment that the tag name City and City2 were intentionally chosen. So you should take care of this decision, before you start changing the tag names City/City2 as you proposed in your first answer.

Thanks for the clarification. I'm not intending to do anything about this. If Gerhard offers a patch, I will review it and consider what you've said.