Activity
From 20 Dec 2009 to 18 Jan 2010
18 Jan 2010
17 Jan 2010
15 Jan 2010
- 03:33 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Added detectCharset() and an optional parameter for the encoding to comment(). The rules to actually detect the chara...
- 03:29 Revision 2006: #662: Added CommentValue::detectCharset and an optional parameter for the encoding...
14 Jan 2010
- 09:02 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- I've refactored the implementation as sketched above, see r2005. It was slightly more hairy than expected because rea...
- 08:54 Revision 2005: #662: Charset conversion on read and write (and if needed on copy).
- 06:46 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Ok. So the exiv2 utility could then work like this:
* By default, it autodetects the comment charset (via CommentV... - 01:38 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Andreas Huggel wrote:
> If an image has a UNICODE comment encoded in UTF-8 (e.g., set using a previous version of Ex...
13 Jan 2010
- 19:45 Bug #562 (Resolved): Exif.Photo.UserComment unicode comment doesn't work (Debian bug #486884)
- Fixed in #662.
- 19:41 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Leo,
If an image has a UNICODE comment encoded in UTF-8 (e.g., set using a previous version of Exiv2), would it be... - 19:27 Bug #662 (Resolved): Incorrect Unicode encoding of Exif UserComment tag
- For Exif UNICODE comments, Exiv2 now expects the input encoded in UTF-8 and serializes it to UCS-2. In addition, spec...
- 19:06 Feature #572 (Resolved): exiv2 tool: It should be possible to insert newlines in text strings.
- Special characters incl. newlines and carriage returns can be escaped now.
- 18:51 Revision 2004: #572: Escape special characters in the JPEG comment (using the new function by Leo...
- 18:26 Revision 2003: #662: Fixes by Leo Sutic. Added carriage return to the special characters.
12 Jan 2010
- 22:23 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Leo Sutic wrote:
> Ok, third (and hopefully final) patch.
Looks good, thanks :)
> This includes the convertStr... - 10:09 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Ok, third (and hopefully final) patch.
This includes the convertStringCharset patch, and fixes printing of comment... - 09:41 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Andreas Huggel wrote:
> And this is the output that I get, related to the issue mentioned above:
>
> [...]
Yes... - 09:40 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Andreas Huggel wrote:
> If it's an overflow, valgrind usually says useful things. The conversion from XMP to Exif is... - 09:34 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- And this is the output that I get, related to the issue mentioned above:...
- 09:31 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Strange, why is your data/bugfixes-test.out so small? Mine is and always was much larger:...
- 09:22 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- I get everything to work expect the bugfixes-test.sh script.
It produces a 62428 byte output file. The correct fil... - 09:19 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- If it's an overflow, valgrind usually says useful things. The conversion from XMP to Exif is in convert.cpp, Converte...
- 09:07 Revision 2002: #662: Updated expected test results.
- 08:29 Revision 2001: #662: Mostly formatting changes and a few tweaks. Move exifcomment tests to bugfix...
- 08:27 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- I'm stuck at conversions.sh, testcase 6. I have the file m.xmp, containing:...
- 06:06 Revision 2000: #662: Patch exiv2-exifcomment-unicode.patch from Leo Sutic (unmodified, without ex...
11 Jan 2010
- 23:02 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- > * Consider adding your test cases to bugfixes-test.sh
Oh you already wrote your own test script. That's fine too... - 22:44 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Leo Sutic wrote:
> I am about to write testcases for the comment handling.
Good. That's commendable.
> I tri... - 15:09 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Second attempt.
- 14:06 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- I am about to write testcases for the comment handling. I tried running the existing tests by cd'ing into test/ and r...
- 07:54 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- I thought I'd fix all the character conversions while I was at it - in particular, convert JIS to UTF8 and UTF8 to JI...
- 04:49 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- > # The difference between value_ and _comment (which should be comment_) is that value_ contains the charset specifi...
- 03:30 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Some comments on your comments:
# The difference between value_ and _comment (which should be comment_) is that va... - 02:15 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Thanks! I finally had a look at it. I have only reviewed the code, not tested it. Some comments:
* Please use Stri...
10 Jan 2010
- 08:00 Revision 1999: #665: Quick-fix for the exiv2 utility to allow inserting Exif data into ORF files.
07 Jan 2010
- 09:52 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Here's the first attempt. Can you tell me how it works for you?
I had to modify convert.cpp to count the number of... - 09:00 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- hi!
With r1998 the function is now part of the API, declared in convert.hpp for want of a better place for now (ut... - 08:55 Revision 1998: Published convertStringCharset() in the API (for #662).
- 07:57 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Ok, I'm back.
I have written the escape-sequence decoder now. It works by first converting everything to UCS-2, an... - 06:39 Revision 1997: #672: Needed to compile on systems with lstat.
06 Jan 2010
- 08:41 Bug #672 (Resolved): Image file gets deleted when writing to it
- 08:37 Revision 1996: #672: Fixed issue with C-string pointer of a temporary.
- 08:25 Bug #672 (Closed): Image file gets deleted when writing to it
- The problem has only been observed on Windows with MSVC compilers
(Reported with reproducer by Thomas Beutlich) - 07:22 Bug #671 (Closed): Writing to read-only TIFF-like file fails
- with a segfault.
mmap() returns 0 due to some problem in switchMode() - 06:26 Revision 1995: Reverted accidental Makefile changes from r1994.
- 04:52 Revision 1994: add Kipi xmp namespace used by digiKam kipi-plugins
04 Jan 2010
- 06:31 Revision 1993: Bumped version to 0.19.1 for testing.
- 05:35 Bug #670 (Rejected): types.cpp fails to compile on MacOS 10.6 because of bindtextdomain
- Closing. Not a bug, see discussion in #669.
- 05:34 Bug #669 (Rejected): Call to iconv fails to compile on MacOS 10.6
- Closing. Not a bug.
- 05:23 Bug #669: Call to iconv fails to compile on MacOS 10.6
- Andreas Huggel wrote:
> Ooohh... So does it work if you unset this?
Uh, yes. :-)
Unsetting the include path so... - 05:09 Bug #669: Call to iconv fails to compile on MacOS 10.6
- Ooohh... So does it work if you unset this?
- 04:54 Bug #669: Call to iconv fails to compile on MacOS 10.6
- Andreas Huggel wrote:
>
> But why does it pick up that from /sw/include in your configure test??
This might hav... - 04:45 Bug #669: Call to iconv fails to compile on MacOS 10.6
- Yes, that's where the conflict comes from.
/usr/include/iconv.h is used on my system too. Also in the configure test... - 04:32 Bug #669: Call to iconv fails to compile on MacOS 10.6
- Apparently, the wrong one is included:...
- 04:24 Bug #669: Call to iconv fails to compile on MacOS 10.6
- Lars Marius Garshol wrote:
> I've attached iconv.h.
>
> Interestingly, make tags.ii fails:
>
> [...]
>
> ta... - 04:16 Bug #669: Call to iconv fails to compile on MacOS 10.6
- I've attached iconv.h.
Interestingly, make tags.ii fails:... - 04:10 Bug #669: Call to iconv fails to compile on MacOS 10.6
- > I can't find any conftest.c file, so I assume you mean iconv.h, which says:
Yes (conftest.c is the little test-p... - 04:02 Bug #669: Call to iconv fails to compile on MacOS 10.6
- I can't find any conftest.c file, so I assume you mean iconv.h, which says:...
- 03:48 Bug #669: Call to iconv fails to compile on MacOS 10.6
- Please also provide the compiler output of the "make tags.ii" command
- 03:44 Bug #669: Call to iconv fails to compile on MacOS 10.6
- > There is an error in the config.log that looks relevant
Yes, this one... - 03:04 Bug #669: Call to iconv fails to compile on MacOS 10.6
- Lars Marius Garshol wrote:
>
> --disable-nls did solve issue #670, but I can't try on this issue before I upload t... - 03:01 Bug #669: Call to iconv fails to compile on MacOS 10.6
- There is an error in the config.log that looks relevant, but you can see for yourself.
--disable-nls did solve iss... - 02:58 Bug #669: Call to iconv fails to compile on MacOS 10.6
- > If you want any of them, let me know, and I'll attach.
Yes, please attach the config.log file (in the top direct... - 01:52 Bug #669: Call to iconv fails to compile on MacOS 10.6
- The install-sh script seems fine:...
- 01:48 Bug #669: Call to iconv fails to compile on MacOS 10.6
- The issue is with the second argument to the iconv function. It is sometimes a char** and sometimes a const char**. T...
- 00:27 Bug #669: Call to iconv fails to compile on MacOS 10.6
- This is exiv2 0.19. I deleted everything, and downloaded again. Output from confingure plus config/config.mk and conf...
03 Jan 2010
- 18:43 Feature #665: Write support for Olympus RAW ORF files
- Apparently ORF files have the same structure as TIFF files except for a different TIFF header magic number (and more ...
- 18:08 Bug #669: Call to iconv fails to compile on MacOS 10.6
- ...and the generated config/config.mk and config/config.h files
- 18:07 Bug #669: Call to iconv fails to compile on MacOS 10.6
- This should be taken care of by the configure script (also the issue reported as #670).
Can you please start from sc... - 09:23 Bug #670 (Rejected): types.cpp fails to compile on MacOS 10.6 because of bindtextdomain
- Having worked around issue #669 I run into this compilation error:...
- 09:02 Bug #669: Call to iconv fails to compile on MacOS 10.6
- The same issue occurs on line 2200 of tags.cpp, and can be worked around in the exact same way.
- 08:58 Bug #669 (Rejected): Call to iconv fails to compile on MacOS 10.6
- In convert.cpp the following lines:...
- 07:20 Revision 1992: #665: Added write-support for ORF files.
- 07:20 Revision 1991: Optimized TiffMappingInfo::operator==().
- 05:40 Feature #668 (Closed): "TIFF-safe" setExifData variant
- For TIFF and TIFF-like images, there should be an interface which just "does the right thing".
Currently, a fair bit...
01 Jan 2010
30 Dec 2009
- 07:50 Bug #661 (Closed): Tag Exif.Image.ImageResources (0x8649 in IFD0) should have type BYTE (1)
- 07:50 Bug #658 (Closed): exception to print raw from Olympus SP-560UZ
- 07:50 Bug #664 (Closed): Crash when reading PNG image
- 07:50 Patch #649 (Closed): Converter fixes
- 07:50 Bug #651 (Closed): Exif tag: TimeZoneOffset (0x882a) missing
- 07:50 Bug #652 (Closed): Problems converting SubSec tags to XMP
- 07:50 Bug #653 (Closed): SVN 1912 fails to build
- 07:50 Bug #647 (Closed): Seg fault with Olympus E-P1 orf
- 07:50 Bug #657 (Closed): Nef Metadata edit with Digikam make impossible to open it with captureNX or Vi...
- 07:50 Bug #656 (Closed): Broken image causes exiv2 to abort (digiKam bug 214913)
- 07:50 Feature #646 (Closed): Additional lens data
- 07:50 Bug #641 (Closed): exiv2 "Image size" output broken for Nikon D700 NEF files
- 07:50 Bug #629 (Closed): Virtual functions should not be inlined
- 07:50 Bug #645 (Closed): Conversion from XMP sidecar leaks XMP-SDK exception. (digiKam bug 204042)
- 07:50 Bug #634 (Closed): Locking error on windows when updating a TIFF file with MemoryMapping enabled
- 07:50 Patch #642 (Closed): string formatting of error #31
- 07:50 Bug #627 (Closed): typeId methods not available, -fvisibility-inlines-hidden
- 07:50 Feature #620 (Closed): Update Nikon makernotes
- 07:50 Bug #617 (Closed): Optimize TIFF writing
- 07:50 Bug #600 (Closed): Upgrade XMP Toolkit to version 4.4.2
- 07:50 Bug #571 (Closed): Need to convert character set when writing XMP sidecar
- 07:50 Feature #579 (Closed): Implement memory mapping for Windows platforms
- 07:50 Bug #581 (Closed): Remove FindMetadatum* from API
- 07:50 Bug #533 (Closed): Support multiple APP13 Photoshop 3.0 segments in a JPEG
- 05:23 Revision 1989: Tagged release 0.19
- 05:18 Revision 1988: Updated Changelog
- 05:17 Revision 1987: Updated translations, just made it... (Michal Smoczyk).
- 03:29 Revision 1986: Pointer acrobatics to workaround MSVC 7.1 problem.
29 Dec 2009
- 22:26 Revision 1985: Minor doc update.
- 19:49 Feature #667 (New): Update Canon makernote
- Use binary arrays to model many currently not decoded tags
- 19:47 Feature #666 (Closed): Optimize binary array elements
- Some binary arrays are large and only a few elements in the array are known.
In such cases, creating a tag for every... - 19:41 Feature #635: [Wish] Write support for Canon RAW CR2 files
- CR2 images have a header with a pointer to the last IFD.
- 19:40 Feature #665 (Closed): Write support for Olympus RAW ORF files
- They seem to have a TIFF/EP structure with a simple extended header.
- 18:45 Bug #663 (Feedback): Failure to write to Jpeg from Canon Ixus - digikam bug 214636
- 08:56 Revision 1984: Tweak.
- 07:24 Revision 1983: Doc updates: added new Nikon and Canon makernote tags, silenced doxygen warnings.
- 06:36 Revision 1982: Minor manpage update.
- 05:44 Bug #664: Crash when reading PNG image
- It's gwenview, crashing on its own as well as konqueror embedding the gwenview component.
libgwenview seems to use l... - 05:29 Revision 1981: Bumped version to 0.19.
- 02:51 Revision 1980: Updated po files.
- 02:47 Revision 1979: Updated ChangeLog for 0.19.
- 02:46 Bug #664 (Resolved): Crash when reading PNG image
- Patch checked-in.
- 02:45 Revision 1978: #664: Check key size before comparing it.
28 Dec 2009
- 20:41 Bug #627 (Resolved): typeId methods not available, -fvisibility-inlines-hidden
- Fixed in #629
- 20:10 Bug #664: Crash when reading PNG image
- > pay attention when clicking under KDE, may also crash konqueror which is using exiv2 through a component
Interes... - 18:43 Bug #664 (Assigned): Crash when reading PNG image
- Attached patch fixes the problem. I'll apply the patch later today and it will be included in 0.19.
- 06:47 Revision 1977: Removed trailing whitespace.
- 06:11 Revision 1976: Added includes for g++-4.4 (Debian 4.4.2-3).
- 05:34 Bug #664: Crash when reading PNG image
- > sorry, didn't manage to compile with debug info
That requires some insider-info:
# make config; ./configure
... - 04:24 Revision 1975: #571: Add Iptc.Envelope.CharacterSet only if any other dataset is added, fixed tests.
- 04:21 Revision 1974: Tweaked test scripts for portability.
- 04:10 Bug #664 (Closed): Crash when reading PNG image
- Exiv2 crashes when reading this PNG image found by a digikam user:
http://bugs.kde.org/attachment.cgi?id=39398
(pay... - 03:52 Revision 1973: Removed one include too many.
27 Dec 2009
- 16:50 Feature #620 (Resolved): Update Nikon makernotes
- Makernotes are moving targets, there are a few more composite tags left, to be implemented in another round, together...
- 16:44 Bug #634 (Resolved): Locking error on windows when updating a TIFF file with MemoryMapping enabled
- 16:44 Feature #579 (Resolved): Implement memory mapping for Windows platforms
- 07:30 Revision 1972: Removed second and third(!) stdio.h include.
- 07:02 Revision 1971: Minor change to make XMP-SDK compile on MinGW with gcc-4.4
- 06:57 Revision 1970: Changed MemIo to use a Pimpl class too (#510).
- 02:54 Revision 1969: Another try to get rid of the DOS newline in a manner which works on other platfor...
- 02:53 Revision 1968: Use [w]path() instead of p_->[w]path_.
- 01:56 Revision 1967: #579: Implemented mmap for Windows directly in FileIo and made that class use the ...
- 01:31 Revision 1966: Minor fix to make MSVC happy.
25 Dec 2009
- 08:15 Revision 1965: Removed --disable-printucs2 configure option.
- 03:31 Revision 1964: Ensure const correctness of iconv arguments.
23 Dec 2009
- 07:31 Revision 1963: #663: Reverted change made in r1961.
- 01:29 Bug #663: Failure to write to Jpeg from Canon Ixus - digikam bug 214636
- Thanks for the feedback, Michael and Volker. I've asked on the digiKam bugtracker and since it's more important to fi...
22 Dec 2009
- 16:38 Bug #663: Failure to write to Jpeg from Canon Ixus - digikam bug 214636
- The change introduced in revision 1961 is dangerous and should be reverted immediately.
The change disables a secu... - 16:15 Bug #663: Failure to write to Jpeg from Canon Ixus - digikam bug 214636
- Hi Andreas, all,
the original Photo1-beforemodif-tagLyon.JPG and Photo2-beforemodif-tagCuisine.JPG in https://bugs... - 03:26 Revision 1962: Added warning.
21 Dec 2009
- 16:43 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- > I am having trouble compiling.
>
> I got Cmake to Configure everything (I think, this is my first time using CMa... - 16:33 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- > How about this rule: Interpret Unicode escapes, but just copy everything else? That way, Ascii with escapes will gi...
- 09:01 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- I am having trouble compiling.
I got Cmake to Configure everything (I think, this is my first time using CMake):
... - 08:27 Bug #662: Incorrect Unicode encoding of Exif UserComment tag
- Andreas Huggel wrote:
> > I think this decoding of unicode escapes can be useful for all values on the command line.... - 07:05 Bug #663: Failure to write to Jpeg from Canon Ixus - digikam bug 214636
- The image Photo2-beforemodif-tagCuisine.JPG has a weird JPEG structure: It contains two APP1 segments with XMP data (...
- 06:44 Revision 1961: #663: Removed check for complete PS data.
20 Dec 2009
- 15:55 Bug #651 (Resolved): Exif tag: TimeZoneOffset (0x882a) missing
- Added TimeZoneOffset (0x882a) and 33 other missing TIFF/EP tags.
- 15:54 Revision 1960: #651: Added TimeZoneOffset (0x882a) and 33 other missing TIFF/EP tags.
- 06:45 Bug #663 (Feedback): Failure to write to Jpeg from Canon Ixus - digikam bug 214636
- Exiv2 fails to write to the sample images provided with digikam bug 214636
( https://bugs.kde.org/attachment.cgi?id=...
Also available in: Atom