Exiv2

Gilles,

This is a small Exiv2-only program to do something similar. I can't
reproduce the issue with this and valgrind is happy (Note:
writeMetadata() writes a warning "Exiv2::PngChunk::parseChunkContent:
Failed to decode Exif metadata" but that doesn't seem to be related.
Tested with buf sizes between 30000 and 4000000. Can you see any
relevant difference to your program/KExiv2? Does valgrind complain
when you run your program?

#include <exiv2/image.hpp>
#include <exiv2/iptc.hpp>
#include <iostream>
#include <iomanip>
#include <cassert>

int main(int argc, char* const argv[])
try {

   if (argc != 2) {
       std::cout << "Usage: " << argv[0] << " file\n";
       return 1;
   }

   Exiv2::Image::AutoPtr image = Exiv2::ImageFactory::open(argv[1]);
   assert(image.get() != 0);
   image->readMetadata();
   Exiv2::IptcData& iptcData = image->iptcData();

   Exiv2::DataBuf buf(4000000);
   memset(buf.pData_, 0x0, buf.size_);
   Exiv2::DataValue val;
   val.read(buf.pData_, buf.size_);
   iptcData["Iptc.Application2.Preview"] = val;
   iptcData["Iptc.Application2.PreviewFormat"]  = 11;
   iptcData["Iptc.Application2.PreviewVersion"] = 1;

   image->writeMetadata();
   return 0;
}
catch (Exiv2::AnyError& e) {
   std::cout << "Caught Exiv2 exception '" << e << "'\n";
   return -1;
}

Regards,
Andreas

Andreas Huggel wrote:

Andi,Andreas,

I can confirm that problem come from exiv2...

In libkexiv2 i have a small test program to update/create iptc preview image in file:

http://lxr.kde.org/source/KDE/kdegraphics/libs/libkexiv2/test/setiptcpreview.cpp

Like you can see this code is very simple : it open file, create iptc preview and save it to file. If you run it to a PNG image (not corrupted, PNG CRC chunk where exif, iptc and xmp are stored become wrong. Using showfoto to load image via libpng return error :

[...]

I'm sure that i have tested indeep chunk writting mode with Exiv2 when 0.18 release have been done. Something is broken in current implementation of Exiv2 from svn.

This is the PNG chunk layout documentation :

http://www.w3.org/TR/PNG/#5Chunk-layout

In Exiv2, CRC are computed to

http://dev.exiv2.org/repositories/entry/exiv2/trunk/src/pngchunk.cpp

Lines 514, 539, and 593...

Best

Gilles Caulier

2009/4/1 Andi Clemens <andi.clemens@gmx.net>:

Now I'm even more confused. The file I converted with imagemagick worked before, now if I use it again with the RemoveRedEyes plugin, it produces the error again and the red eyes disappear only when opened in the editor.

Right now I have to do other things, maybe tonight or tomorrow I will change the metadata and check it again...

Andi

On Wednesday 01 April 2009 20:07:05 you wrote:

2009/4/1 Andi Clemens:

Ok so changing the metadata as you suggested is only for testing the CRC error?

yes...

I thought it has something to do with the wrong displaying of the image in AlbumUI but maybe it has?)...

I will alter the metadata now and see if the CRC error appears.

ok

Gilles

Andreas,

Sorry for my late response about this problem, but i have been very busy last week end.

I will investiguate indeep soon

Gilles Caulier

Gilles, do you still see this problem with new PNG write code?

Andreas Huggel wrote:

Gilles, do you still see this problem with new PNG write code?

No, no, it fixed now with current Exiv2 code...

Gilles