Feature #894

Canon Highlight Tone Priority

Added by Pascal de Bruijn about 4 years ago. Updated 8 months ago.

Status:AssignedStart date:17 Mar 2013
Priority:NormalDue date:
Assignee:Ben Touchette% Done:

50%

Category:exifEstimated time:10.00 hours
Target version:0.27

Description

Hi,

Recent Canon camera's have a feature called Highlight Tone Priority (HTP), which is described as such:

"Highlight tone priority shoots at an ISO speed one stop lower (1ev underexposure) then compensates for this in RAW processing."

Currently it seems Exiv2 can't tell us if a file was shot with HTP On or Off.

http://files.pcode.nl/temp/HTP.CR2

On a side note ExifTool apparently can read the HTP status:

$ exiftool HTP.CR2 | grep -i highlight
Highlight Tone Priority : Enable

Regards,
Pascal de Bruijn

894-5.diff Magnifier (8.04 KB) Ben Touchette, 15 Sep 2016 14:11


Related issues

Related to Exiv2 - Feature #1219: Adding Camera Temperature Assigned 31 Aug 2016
Related to Exiv2 - Bug #1203: Exif.CanonCs.FocusContinuous reported as Short Assigned 11 Aug 2016

History

#1 Updated by Robin Mills about 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Niels Kristian Bech Jensen
  • Priority changed from Low to Normal
  • Target version set to 0.24

Neils

May I ask you to take a look at this. Pascal works on DarkTable - a really awesome open-source project. I feel guilty that I haven't picked this up already. I'm a little overwhelmed at the moment (especially with Google Summer of Code). If you can't deal with this, please assign this back to me.

Robin

#2 Updated by Niels Kristian Bech Jensen about 4 years ago

Hi Robin.

I have students up for final exams during the next month, so time is limited. I will look into this when exam season is over.

Best regards,
Niels Kristian Bech Jensen

#3 Updated by Pascal de Bruijn about 4 years ago

No need for any guilt :)

Being able to detect HTP isn't critical, but it would be nice too have, as it would allow us to automatically compensate for the cases where people either purposefully or accidentally enabled HTP.

#4 Updated by Robin Mills almost 4 years ago

  • Target version changed from 0.24 to 0.25

Deferred for 0.25.

#5 Updated by Alan Pater about 2 years ago

Is there another sample file that can demonstrate this issue? Not even exiftool shows this field for the linked HTP.CR2 file.

#6 Updated by Pascal de Bruijn about 2 years ago

I think I accidentally deleted that file over time, I'll need to dig up a new sample soon. Stay tuned.

#7 Updated by Alan Pater almost 2 years ago

  • Target version changed from 0.25 to 0.26

#8 Updated by Niels Kristian Bech Jensen almost 2 years ago

  • Assignee deleted (Niels Kristian Bech Jensen)

#9 Updated by Robin Mills 12 months ago

  • Assignee set to Robin Mills

Pascal

Can you provide an image and I will investigate. I'm closing on v0.26 at the end of June. Now's the time. tick tick tick ....

Hope you're good.

Robin

#10 Updated by Pascal de Bruijn 11 months ago

So I don't own a Canon camera with HTP, but I asked around and I got permission to supply you with these:

(from a 7D and a 5DmkII, courtesy of andabata)
http://shell.kees.nl/dt/

(from an 80D, courtesy of dabbill)
https://www.dropbox.com/sh/9ecn3zi3gfub7tx/AABzvKEBqPk7qglKuJdQKKBTa?dl=0

#11 Updated by Ben Touchette 8 months ago

Work in progress. Working on differentiating between models with and without highlight tone priority.

#12 Updated by Robin Mills 8 months ago

  • Assignee changed from Robin Mills to Ben Touchette
  • Target version changed from 0.26 to 0.27
  • % Done changed from 0 to 50
  • Estimated time set to 10.00

Thanks for working on this, Ben. I'm going to defer this for v0.27. This issue has elements in common with #1203 and #1219.

Reading and writing those tags isn't simple and I've never worked in the MakerNote decode/encode code. Raphael is working on #1219 and I think he's going to visit me in England in October. We'll discuss all of these issues when he's here. I know that Shridar is very anxious for #1203 to be included in v0.26. It may be possible to include fixes for all three issues in v0.26, however the project is already at feature complete.

#13 Updated by Robin Mills 8 months ago

I've built and reviewed your code. What you have done looks about right to me. It's reporting lots of metadata that has never seen the light of day before. The following parts of the test suite have been disturbed by this:

651 rmills@rmillsmbp:~/gnu/exiv2/trunk $ make tests | grep differ
Files test/tmp/bugfixes-test.out-stripped and trunk/test/data/bugfixes-test.out differ
Files test/tmp/exifdata-test.out and test/data/exifdata-test.out differ
Files test/tmp/exiv2-test.out and test/data/exiv2-test.out differ
Copy all tests......
Files test/tmp/table.jpg.c3tst and test/data/table.jpg.c3gd differ
Files test/tmp/smiley1.jpg.c3tst and test/data/smiley1.jpg.c3gd differ
Files test/tmp/write-test.out and test/data/write-test.out differ
652 rmills@rmillsmbp:~/gnu/exiv2/trunk $ 
We're going to have to defer this at the moment.

Incidentally, I had to edit the patch to have it respected by SVN. The preferred way to make a patch is to use:

$ cd ~/gnu/exiv2/trunk
$ svn diff . > foo.patch
Thanks for working on this.

#14 Updated by Ben Touchette 8 months ago

Thanks and welcome, i concur for the deferment due to the number of issues to make this functional at this time.

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux