Bug #873

Samsung SRW Makernote disappearing

Added by Pascal de Bruijn over 6 years ago. Updated over 2 years ago.

Status:NewStart date:18 Dec 2012
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:exif
Target version:0.28

Description

When moving EXIF from a Samsung SRW/RAW file to an output JPG file (in Darktable) everything is fine.

But when I added a little bit of code to remove Exif.Photo.CFAPattern the MakerNote Exif.Samsung2.* suddenly disappears. This is the commit:
https://github.com/darktable-org/darktable/commit/a884abb7a9ec4ec37bc4c34e8d0cbf779b14822f

I put the commit in a special branch:
https://github.com/darktable-org/darktable/tree/srw-makernote-bug

Sample SRW:
http://files.pcode.nl/temp/srw/SAM_1318.SRW

Before everything is fine:
http://files.pcode.nl/temp/srw/before_SAM_1318.jpg

After the Exif.Samsung2.* is missing:
http://files.pcode.nl/temp/srw/after_SAM_1318.jpg

I've tested this using Exiv 0.23 with the following changesets cherry-picked: r2743 r2744 r2756 r2818

History

#1 Updated by Pascal de Bruijn over 6 years ago

From r1818 only the canonmn.cpp changes were cherry-picked btw:
http://dev.exiv2.org/projects/exiv2/repository/revisions/2818/diff/branches/gsoc2012/src/canonmn.cpp

I also forgot to mention that this seems specific to SRW/Exif.Samsung2 when I remove Exif.Photo.CFAPattern during export to JPEG for other manufacturers RAW files, their MakerNotes seem to be retained.

Also this issue doesn't seem to be specific to Exif.Photo.CFAPattern, any change to Exif.Photo.* seems to be problematic for Samsung's Makernote.

During export, I see the following warnings/errors, but these occur both before and after the change (so with and without the MakerNote present in the resulting file):
Warning: Exif tag Exif.SamsungPreview.JPEGInterchangeFormatLength not encoded
Warning: Exif IFD SamsungPreview not encoded
Warning: Exif tag Exif.Photo.MakerNote not encoded
Warning: Exif tag Exif.Samsung2.0x0060 not encoded
Warning: Exif tag Exif.Samsung2.0x0080 not encoded
Warning: Exif tag Exif.Samsung2.0x00a0 not encoded
Warning: Exif tag Exif.Samsung2.0x00c0 not encoded
Error: Upper boundary of data for directory Photo, entry 0xa302 is out of bounds: Offset = 0x00001ae6, size = 8, exceeds buffer size by 6 Bytes; truncating the entry
Error: Upper boundary of data for directory Photo, entry 0xa302 is out of bounds: Offset = 0x00001ae6, size = 8, exceeds buffer size by 6 Bytes; truncating the entry

Please let me know if you need any more additional information.

#2 Updated by Robin Mills over 3 years ago

  • Target version set to 0.26

#3 Updated by Robin Mills over 2 years ago

  • Target version changed from 0.26 to 0.28

Pascal

Regrettably, I have to defer this again. I've put in around 1200 hours of effort to get to code complete v0.26 and closed almost 200 issues. Regrettably, there are only 5 or 6 issues on which I have not worked. This is one. Deferred for v0.27.

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux