Patch #1362

Fix Clang build

Added by David Carlos Manuelda 13 days ago. Updated 11 days ago.

Status:ClosedStart date:04 Aug 2018
Priority:NormalDue date:
Assignee:Robin Mills% Done:

100%

Category:buildEstimated time:1.00 hour
Target version:0.27

Description

Clang does not admit -std=gnu++98 for C, as it is a C++ flag, thus it fails with error despite gcc and other seems to accept it even in C mode.

The fix is pretty simple, by using CMAKE_C_FLAGS instead of ADD_DEFINITIONS for setting that flag (also ADD_DEFINITIONS is not supposed to use for other kind of flags which are not -DXXXX).

fix-clang-build.patch Magnifier (641 Bytes) David Carlos Manuelda, 04 Aug 2018 14:27

History

#1 Updated by Robin Mills 12 days ago

  • Category set to build
  • Status changed from New to Assigned
  • Assignee set to Robin Mills
  • Target version set to 0.27
  • % Done changed from 0 to 10
  • Estimated time set to 2.00

Thanks for reporting this and providing the patch.

I'm very surprised by this because I use a Mac as my development machine on which the compiler is clang. I'll investigate your patch on Linux/clang and get back to you.

I'm on vacation at the moment and will do the work as time permits.

#2 Updated by David Carlos Manuelda 12 days ago

An important fact is that it fails with clang-6, not with previous versions as the if condition above is not met.

#3 Updated by Robin Mills 12 days ago

Ah. Thanks for letting me know about that detail.

You're welcome to submit a PR to https://github.com/exiv2/exiv2.git

#4 Updated by Robin Mills 12 days ago

David

I'm on vacation in Montana, USA and can't get clang to download. I think something's blocking my internet connection. Can you submit a PR on https://github.com/exiv2/exiv2 and another member of Team Exiv2 will give this attention.

Robin

#5 Updated by David Carlos Manuelda 12 days ago

Sure, will do tomorrow, thanks for your attention and enjoy your hollydays :)

#6 Updated by David Carlos Manuelda 11 days ago

I've reviewed github repository, seems it is already fixed there, I was affected probably by an old snapshot of exiv2 for Gentoo.

Sorry for the inconvenience :)

#7 Updated by Robin Mills 11 days ago

  • Status changed from Assigned to Closed
  • % Done changed from 10 to 100
  • Estimated time changed from 2.00 to 1.00

Thanks for the update, David. It's good to hear that this is working for you. Thank You for using Exiv2 and Thank You for engineering a patch.

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux