Bug #1304

Lens missing Tamron SP 90mm f/2.8 Di Macro 1:1 VC USD F017

Added by Matze G 24 days ago. Updated 10 days ago.

Status:AssignedStart date:26 Jul 2017
Priority:NormalDue date:
Assignee:Robin Mills% Done:

50%

Category:lensEstimated time:2.00 hours
Target version:v0.26.1

Description

I found out that exiv2 does not handel following lens correctly:

Lens name:
Tamron SP 90mm f/2.8 Di Macro 1:1 VC USD (Tamrons website)
Tamron SP AF 90mm 2.8 Di VC USD Makro 1:1 (also often found, e.g. shops)

Lens' product page:
http://www.tamron.eu/lenses/sp-90mm-f28-di-macro-11-vc-usd/

Note:
There are two lenses from Tamron share the exact same name (but different optics/electronic), an older version (known by the internal code F004) and the newer (code F017). (Here is an overview off all Tamron 90mm macro lenses https://geizhals.at/?fs=Tamron+SP+AF+90mm+2.8+Di+VC+USD+Makro+1%3A1+f%FCr+Canon&in= ).

$ exiv2 -pt _MG_2698.CR2 | grep -ai lens
Exif.CanonCs.LensType                        Short       1  Canon EF 100mm f/2.8L Macro IS USM
Exif.CanonCs.Lens                            Short       3  90.0 mm
Exif.Canon.LensModel                         Ascii      70  TAMRON SP 90mm F/2.8 Di VC USD MACRO1:1 F017
Exif.Photo.LensSpecification                 Rational    4  90/1 90/1 0/0 0/0
Exif.Photo.LensModel                         Ascii      70  TAMRON SP 90mm F/2.8 Di VC USD MACRO1:1 F017
Exif.Photo.LensSerialNumber                  Ascii      12  0000000000
$ exiv2 -V
exiv2 0.26 001a00 (64 bit build)
I found following realted names in http://dev.exiv2.org/projects/exiv2/repository/entry/trunk/src/canonmn.cpp#L755 :
  1. Tamron 90mm f/2.8
    (is this this http://www.tamron.eu/lenses/sp-af-90mm-f28-di-macro-11/ lens (an even older than the F004)?
  2. Tamron SP AF 90mm f/2.8 Di Macro
    (is this the F004?)

I hope i have included all needed informations

Thank you in advance for fixing it

TamronSP90mmF2.8DiMACROVCUSDF017.JPG - A picture taken with the Tamron 90 mm F017 (457 KB) Matze G, 26 Jul 2017 12:55


Related issues

Related to Exiv2 - Patch #1306: the lens TAMRON SP 15-30mm F/2.8 Di VC USD A012 is not pr... Assigned 29 Jul 2017

History

#1 Updated by Robin Mills 24 days ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100
  • Estimated time set to 1.00

Good News, you can fix this for yourself! When I run your test file, I see:

537 rmills@rmillsmbp:~/gnu/exiv2/0.26 $ exiv2 -pa --grep lens/i TamronSP90mmF2.8DiMACROVCUSDF017.JPG 
Exif.CanonCs.LensType                        Short       1  Canon EF 100mm f/2.8L Macro IS USM
Exif.CanonCs.Lens                            Short       3  90.0 mm
Exif.Canon.LensModel                         Ascii      70  TAMRON SP 90mm F/2.8 Di VC USD MACRO1:1 F017
Exif.Photo.LensSpecification                 Rational    4  90/1 90/1 0/0 0/0
Exif.Photo.LensModel                         Ascii      70  TAMRON SP 90mm F/2.8 Di VC USD MACRO1:1 F017
Exif.Photo.LensSerialNumber                  Ascii      12  0000000000
538 rmills@rmillsmbp:~/gnu/exiv2/0.26 $ 
It's possible to change the value of Exif.CanonCs.LensType by setting it in ~/.exiv2. The value of this tag is 254:
538 rmills@rmillsmbp:~/gnu/exiv2/0.26 $ exiv2 -pv --grep lenstype/i TamronSP90mmF2.8DiMACROVCUSDF017.JPG 
0x0016 CanonCs      LensType                    Short       1  254
539 rmills@rmillsmbp:~/gnu/exiv2/0.26 $ 
You can declare that in ~/.exiv2 as follows:
[canon]
254=Matze's Tamron Lens
539 rmills@rmillsmbp:~/gnu/exiv2/0.26 $ exiv2 -pa --grep lenstype/i TamronSP90mmF2.8DiMACROVCUSDF017.JPG 
Exif.CanonCs.LensType                        Short       1  Matze's Tamron Lens
540 rmills@rmillsmbp:~/gnu/exiv2/0.26 $ 

There's a discussion about this feature here: http://dev.exiv2.org/boards/3/topics/2854?r=2861#message-2861

#2 Updated by Robin Mills 22 days ago

  • Assignee set to Robin Mills

#3 Updated by Matze G 19 days ago

Thank you for your extensive answere!
But I was not happy to fix this only for myself, so i pulled the code from github and made the requiered changes in the canonmn.cpp. See my pullrequest on github: https://github.com/Exiv2/exiv2/pull/20

#4 Updated by Robin Mills 19 days ago

  • Status changed from Closed to Assigned
  • % Done changed from 100 to 50
  • Estimated time changed from 1.00 to 2.00

Thanks very much. Please see my comments in #1306 about this patch.

#5 Updated by Robin Mills 10 days ago

Matze

I haven't forgotten your patch. We've been undertaking a major change for v0.26.1 and have broken the build and test suite. Since I returned from vacation last week, my priority has been to get everything stable and I hope to achieve that today. I've got a couple of patches and 2 pull requests to deal with and hope they will be done this week.

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux