New lens: Sigma 18-35mm f/1.8 DC HSM Art for Canon
|Status:||Closed||Start date:||15 Jul 2017|
|Assignee:||Robin Mills||% Done:|
|Category:||metadata||Estimated time:||1.00 hour|
The attached patch adds the lens ID for Sigma's 18-35mm lens for Canon. Detection for this lens used to work for me in past, but I probably ran a patched version of exiv2 and forgot to submit the patch.
#2 Updated by Robin Mills 11 months ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
- Estimated time set to 1.00
I've submitted your patch. Thank you for sending this. If you have a suitable test file, I'll add it to our test suite as a "regression detector". It's rather important to have a test file for this lens. As you have noticed, there are 5 lenses with the id 150. It's entirely likely that your "fix" will break when another lens with id=150 is added. By having your test file in the test suite, we'll know that your fix requires attention.
With Exiv2 v0.26, we added a feature to enable users to add their own lens definitions to Exiv2 in the file ~/.exiv2. This is discussed in some detail here: http://dev.exiv2.org/boards/3/topics/2854