Bug #1294

tags.cpp: linebreaks in description of 0xc763, "TimeCodes"

Added by Norbert Wagner 5 months ago. Updated 5 months ago.

Status:ClosedStart date:07 May 2017
Priority:NormalDue date:
Assignee:Robin Mills% Done:

100%

Category:miscellaneousEstimated time:1.00 hour
Target version:0.27

Description

Bug is maybe to hard, it is more an observation ...
In tags.cpp, one description line for "TagInfo(0xc763, "TimeCodes", N_("TimeCodes")," contains "\n\n". Due to this the output from taglist.exe contains one empty line in between and one line which does not fit to the table-structure. So I think, this "\n\n" was not intended but a kind typing or copy error.


Related issues

Related to Exiv2 - Feature #1180: Add tags defined by Adobe in the Cinema DNG Specification Closed 25 Apr 2016

History

#1 Updated by Robin Mills 5 months ago

  • Category set to miscellaneous
  • Status changed from New to Assigned
  • Assignee set to Robin Mills
  • Priority changed from Low to Normal
  • Target version set to 0.27

Norbet

I don't know anything about this code as Niels has been the expert. When Exiv2 v0.26 was released, Niels retired from the project. I know he was very careful to keep all of this in line with ExifTool. If you have a test file, you could compare the output from Exiv2 and ExifTool. If you don't have a test file, the change you're proposing sounds OK to me. "OK" = I can't see any harm in changing this.

I'm having a short break from Exiv2 at the moment.

The code is now being stored on GitHub and I haven't submitted any changes since the release on 4/28. Perhaps you could update your code and submit a pull request. I believe Ben (draekko) will review and add it to the master (or trunk or whatever it's called on Git). https://github.com/Exiv2/exiv2

#2 Updated by Robin Mills 5 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100
  • Estimated time set to 1.00

I've submitted a fix: https://github.com/Exiv2/exiv2/commit/9be72eececd332fdd35a7ceaaa3d516e4bb4473b

I believe you are correct that this is a cut'n'paste issue. I added that code last year in response #1180 I think the string in the code was copied from the Adobe specification. http://wwwimages.adobe.com/content/dam/Adobe/en/devnet/cinemadng/pdfs/CinemaDNG_Format_Specification_v1_1.pdf

Thanks for reporting this.

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux