Bug #1218

Fix test harness for r4438

Added by Robin Mills over 2 years ago. Updated over 2 years ago.

Status:AssignedStart date:30 Aug 2016
Priority:NormalDue date:
Assignee:Robin Mills% Done:

30%

Category:testingEstimated time:10.00 hours
Target version:0.28

Description

Sridhar's submission r4438 was committed to deal with #1204, #1205 and #1206. This has introduced numerous anomalies being reported by the test harness. Robin has agreed to undertake the investigation to correct the anomalies.

Associated revisions

Revision 4448
Added by Robin Mills over 2 years ago

#1218 Work-in-progress on test/exifdata-test.sh

History

#1 Updated by Robin Mills over 2 years ago

  • % Done changed from 20 to 30
  • Estimated time changed from 4.00 to 10.00

This was discovered an partly documented in http://dev.exiv2.org/issues/1203#note-13

At that time, we were aware of:
1 write-test.sh is reporting concerning Exif.CanonSi.MeasuredEV2
2 imagetest.sh is reporting an issue concerning smiley2.jpg.c3tst
3 webp-test.sh is reporting: < Warning: Unsupported time format

Item 3 has been fixed: r4447

I've discovered there is something odd about exifdata-test.sh. It's very strange as the test seems to be failing about once for every four times it is run with a grumble about Exif.CanonSi.MeasuredEV2. Curiously similar to write-test.sh

Groan. I don't know why I agreed to take a major change into the code at this stage in v0.26. I do it to please others and end up with a load of work I didn't expect.

Three known defects:
1 write-test.sh is reporting concerning Exif.CanonSi.MeasuredEV2
2 imagetest.sh is reporting an issue concerning smiley2.jpg.c3tst
3 exifdata-test.sh sometimes reports Exif.CanonSi.MeasuredEV2

#2 Updated by Robin Mills over 2 years ago

  • Target version changed from 0.26 to 0.28

Fixes submitted. Rollback r4450. Branch trunk/4448 to branches/develop r4449.

We’ve destabilised Exiv2 with r4438. It’s causing the test harness to behave in a way that I have never seen before. And I want to reach feature complete on v0.26.

The children of r4438 are 4439, 4441, 4442, 4446 and 4448. I’ve performed this operation locally and it builds and passes the test suite.

We can pick up on this after v0.26 is feature complete. Or fix this on branches/develop.

r4438 is a rather complicated change that deals with several different issues (#1203/4/5/6).

r4438 | sridharb | 2016-08-26 06:36:05 +0100 (Fri, 26 Aug 2016) | 83 lines
Changed paths:                             ROLL-BACK:
   M /trunk/include/exiv2/exif.hpp
   M /trunk/include/exiv2/exv_msvc.h
   M /trunk/include/exiv2/image.hpp
   M /trunk/include/exiv2/tags.hpp
   M /trunk/src/canonmn.cpp
   M /trunk/src/image.cpp
   M /trunk/src/tags.cpp
   M /trunk/src/version.cpp

------------------------------------------------------------------------
r4439 | sridharb | 2016-08-26 07:27:52 +0100 (Fri, 26 Aug 2016) | 2 lines
Changed paths:                             ROLL-BACK:
   M /trunk/src/canonmn.cpp
Summary: Restored jbeu's formatting

------------------------------------------------------------------------
r4440 | robinwmills | 2016-08-26 10:54:50 +0100 (Fri, 26 Aug 2016) | 1 line
Changed paths:                             KEEP: Useful patch
   M /trunk/src/tags.cpp    
#1214 Patch submitted r4440.  Thank You to Ondřej for reporting this and providing the patch.

------------------------------------------------------------------------
r4441 | sridharb | 2016-08-26 12:15:51 +0100 (Fri, 26 Aug 2016) | 2 lines
Changed paths:                             ROLL-BACK:
   M /trunk/src/canonmn_int.hpp
Needs to be in the solution.

------------------------------------------------------------------------
r4442 | sridharb | 2016-08-26 14:35:50 +0100 (Fri, 26 Aug 2016) | 6 lines
Changed paths:                             ROLL-BACK:
   M /trunk/include/exiv2/exif.hpp
   M /trunk/src/exif.cpp
Moved ExifDatum::ignore from exif.hpp to the exif.cpp to free exif.hpp includeing tags_int.hpp.

------------------------------------------------------------------------
r4443 | robinwmills | 2016-08-27 18:35:36 +0100 (Sat, 27 Aug 2016) | 1 line
Changed paths:                             KEEP: Not involved with r4438
   A /trunk/contrib/CLion
   ...
CLion IDE support.  Thank You, Ben.  This is really useful.  See contrib/CLion/ReadMe.txt for explanation.
------------------------------------------------------------------------
r4444 | robinwmills | 2016-08-27 18:36:29 +0100 (Sat, 27 Aug 2016) | 1 line
Changed paths:
   M /trunk/src/webpimage.cpp              KEEP: Not involved with r4438
#1199 Fixing build-breaker when -DDEBUG is used.

------------------------------------------------------------------------
r4446 | robinwmills | 2016-08-30 07:58:50 +0100 (Tue, 30 Aug 2016) | 1 line
Changed paths:                             ROLL-BACK:
   M /trunk/test/data/bugfixes-test.out
   M /trunk/test/data/exifdata-test.out
   M /trunk/test/data/exiv2-test.out
   M /trunk/test/data/write-test.out
#1203 Fixing test suite to respect changes introduced by r4438

------------------------------------------------------------------------
r4447 | robinwmills | 2016-08-30 08:32:14 +0100 (Tue, 30 Aug 2016) | 1 line
Changed paths:                             KEEP: I should have dealt with this last week
   M /trunk/test/data/webp-test.out
   M /trunk/test/webp-test.sh
#1203 test/webp-test.sh - silence warning about time format.

------------------------------------------------------------------------
r4448 | robinwmills | 2016-08-30 11:53:35 +0100 (Tue, 30 Aug 2016) | 1 line
Changed paths:                             ROLL-BACK:
   M /trunk/test/data/exifdata-test.out    
   M /trunk/test/exifdata-test.sh
#1218 Work-in-progress on test/exifdata-test.sh

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux