Feature #1060

ISO speed readout & low-light cameras

Added by Robin Mills over 2 years ago. Updated 11 months ago.

Status:ClosedStart date:22 Apr 2015
Priority:NormalDue date:
Assignee:Thomas Beutlich% Done:

100%

Category:metadataEstimated time:10.00 hours
Target version:0.26

src__easyaccess_cpp.diff Magnifier - Diff for src/easyaccess.cpp (3.39 KB) Spex Duplex, 10 May 2015 07:58

test__Makefile.diff Magnifier - Diff for test/Makefile (406 Bytes) Spex Duplex, 10 May 2015 07:58

iso65k-test.sh Magnifier - test/iso65k-test.sh (7.12 KB) Spex Duplex, 10 May 2015 07:58

iso65k-test.out - test/data/iso65k-test.out (6.1 KB) Spex Duplex, 10 May 2015 07:58

T1060.patch Magnifier (4.63 KB) Thomas Beutlich, 24 Aug 2016 19:25

Associated revisions

Revision 4451
Added by Robin Mills 11 months ago

#1060 Thank you to Thomas B for working on this and providing the patch.

Revision 4452
Added by Robin Mills 11 months ago

#1060 Resequenced tests in alphabetic order.

History

#1 Updated by Spex Duplex about 2 years ago

Ok, that took a bit longer than I wanted, because these things are lying around for about 2 weeks already. Anyway ...

Added a patch for easyaccess.cpp as well as test related files + Makefile patch.

Note: code quality is probably not up to par for easyaccess.cpp, used while + break to avoid nesting, for example.

#2 Updated by Thomas Beutlich 11 months ago

Attached is a slightly updated patch for easyaccess.cpp and test/Makefile.

#3 Updated by Robin Mills 11 months ago

  • Status changed from New to Assigned
  • Assignee set to Thomas Beutlich
  • % Done changed from 0 to 80
  • Estimated time set to 4.00

Thomas

I've submitted you patch and test script. Thank you doing this work. I don't know anything about the code you have modified here, however it builds and passes the test suite with the autotools and CMake. Can I ask you to update the "Estimated time" to reflect the effort that this took. If you believe this is complete, please mark it "Closed".

#4 Updated by Thomas Beutlich 11 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 80 to 100
  • Estimated time changed from 4.00 to 10.00

Well, the patch was developed to Spex Duplex. Estimated work: 10h.

#5 Updated by Robin Mills 11 months ago

Ah, yes. You've taken his code and made it into a patch. Thanks to you both for working on this. Almost there with v0.26, thank goodness.

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux