Support #1045

Add COPYRIGHT file to test/data/

Added by Robin Mills about 2 years ago. Updated over 1 year ago.

Status:ClosedStart date:25 Mar 2015
Priority:NormalDue date:
Assignee:Alan Pater% Done:

100%

Category:testingEstimated time:10.00 hours
Target version:0.26

Associated revisions

Revision 3641
Added by Robin Mills about 2 years ago

#1045. Adding test/data/COPYRIGHT notice.

History

#1 Updated by Robin Mills about 2 years ago

  • Target version changed from 0.25 to 0.26

Fix submitted. r3941. I'm also going to move the target version to v0.26. The task to add the following tags to every test image is not trivial:

  1. Exif.Image.Copyright
  2. Iptc.Application2.Copyright
  3. Xmp.dc.rights

I have no idea of the origin of many of the test files. We really should go through this stuff and remove anything that really is not needed. We can use the sample application metacopy to make small image files which have a copy of the original metadata and a simple tiny image. This would reduce the size of test/data and remove the graphical image which is all that many image owners consider to be their property.

I'd very much like to recruit a test engineer to manage our test suite. I hope this will happen during development of v0.26 and this task will be assigned to the test engineer.

#2 Updated by Alan Pater about 2 years ago

I have been thinking about this and soliciting opinions from others.

Consensus seems to be that any files (including images) included with exiv2 should have the same license as exiv2. That is: GPL version 2 or greater.

Also, it seems we don't need a separate test/data/COPYRIGHT notice. The test data inherits copyright and license from the project. If there is a different license/copyright for the test data, that information is listed in the project copyright file as an exception.

This also means that we don't need to add any copyright or license tags to the images themselves. If we did need to, we also need Xmp.xmpRights.UsageTerms for the license itself (GPL). The other tags are for copyright. But we can't add tags to all test images, it may invalidate the tests. And some images don't support changes, for example, preview images.

I suggest going forward that we have a checkable statement on the upload form that says something like: "By uploading images here, you agree to assign copyright to exiv2 and license those images under the GPL v2 or greater." And perhaps: "If you don't agree, we will only use your images for testing, we will not include them in the program." That last option is more work for us, but would perhaps be needed to ensure maximum participation in the project.

#3 Updated by Robin Mills about 2 years ago

I like the idea of the text about "By uploading ... you agree ...". We are giving away our time, talent and code. If a user wants to retain image (or any other) copyright, we don't want their materials. They are "off side".

We aren't interested in the image, only metadata. A user can extract metadata into a .exf file.

$ exiv2 -f -ea X.jpg
916 rmills@rmillsmbp:~/gnu/exiv2/trunk $ ls -alt X.*
-rw-r--r--+ 1 rmills  staff    17685 26 Apr 20:24 X.exv
-rw-r--r--@ 1 rmills  staff  7169623 26 Apr 20:23 X.jpg
$ exiv2 -pS X.exv 
STRUCTURE OF JPEG FILE: X.exv
 address | marker     | length  | data
       2 | 0x1      
       9 | 0xe1 APP1  |   14868 | Exif..II*.....................
   14879 | 0xe1 APP1  |    2720 | http://ns.adobe.com/xap/1.0/.<
   17601 | 0xed APP13 |      82 | Photoshop 3.0.8BIM.......6....
   17685 | 0xd9 EOI  
$ exiv2 -pS X.jpg
STRUCTURE OF JPEG FILE: X.jpg
 address | marker     | length  | data
       2 | 0xd8 SOI  
       4 | 0xe1 APP1  |   14862 | Exif..II*.....................
   14868 | 0xe1 APP1  |    2720 | http://ns.adobe.com/xap/1.0/.<
   17590 | 0xed APP13 |     110 | Photoshop 3.0.8BIM.......6....
   17702 | 0xe2 APP2  |    4094 | MPF.II*...............0100....
   21798 | 0xdb DQT   |     132 
   21932 | 0xc0 SOF0  |      17 
   21951 | 0xc4 DHT   |     418 
   22371 | 0xda SOS   |      12 
$ 
This is better for us. We don't want big fat images in the test suite.

#4 Updated by Alan Pater about 2 years ago

I've added a note on the wiki advising that contributions need to licensed the same (GPL v2) as the exiv2 source code.

http://dev.exiv2.org/projects/exiv2/wiki/Contributing_to_Exiv2/11

#5 Updated by Robin Mills about 2 years ago

  • Assignee deleted (Robin Mills)

#6 Updated by Alan Pater over 1 year ago

  • Status changed from Assigned to Rejected
  • Assignee set to Alan Pater
  • % Done changed from 0 to 100
  • Estimated time set to 10.00

My conclusion after researching this is that no additional copyright or license file is needed in test/data.

The COPYING file at the root of the source automatically applies to all sub-directories and files. All files under the root directory inherit the same license and copyright.

#7 Updated by Robin Mills over 1 year ago

  • Status changed from Rejected to Closed

I'm going to change the status to "Closed" as it fits in better with our "Progress" accounting on: http://dev.exiv2.org/news/2

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux