Bug #1004

Missing German translation

Added by Thomas Beutlich almost 3 years ago. Updated over 2 years ago.

Status:ClosedStart date:25 Nov 2014
Priority:NormalDue date:
Assignee:Thomas Beutlich% Done:

0%

Category:translation
Target version:0.25

Description

In OpenSUSE 13.2 (German) I printed the help text of exiv2. German translation for flags fc, -q, -Q, -u, -g, -n, -p, -P, -e is missing.

help.txt Magnifier (5.73 KB) Thomas Beutlich, 25 Nov 2014 21:23

T1004.patch Magnifier (12.4 KB) Thomas Beutlich, 04 Jan 2015 21:34

T1004_2.patch Magnifier (23.2 KB) Thomas Beutlich, 05 Jan 2015 20:48

T1004_3.patch Magnifier (1.21 KB) Robin Mills, 16 Jan 2015 12:22

Associated revisions

Revision 3513
Added by Robin Mills over 2 years ago

#1004. Reviewed all include directives in src/*.cpp and samples/*.cpp
fixed svn_version.sh again!
change to test/build-test.py for MacOS-X/Xcode 6.

Revision 3560
Added by Robin Mills over 2 years ago

#1004. Thank You Thomas for the patch.

Revision 3568
Added by Robin Mills over 2 years ago

#1004. Thank You to Thomas Schmidt for the patch.

History

#1 Updated by Robin Mills almost 3 years ago

  • Status changed from New to Assigned
  • Assignee set to Robin Mills
  • Priority changed from Low to Normal
  • Target version set to 0.25

Thanks for providing this, Thomas. i think we have to update <exiv2-dir>/po/de.po appropriately. If you have time to create and test a patch, I'd appreciate your help.

If you don't have time, please update this and I'll do my best. Or I might assign this to Andreas for a couple of reasons:

  1. I believe Andreas knows how the i18n code works.
  2. He speaks german and can more easily validate the fix.

Robin

#2 Updated by Robin Mills almost 3 years ago

  • Assignee changed from Robin Mills to Thomas Beutlich

Thomas

I'm going to push this back to you for fixing. You speak german and I don't! If you could provide a patch (against the head of trunk) and attach it to this bug report, I will build, test and submit it.

Currently I don't believe we have anything in our test suite to test our i18n support. The test suite's in bash and you might find that interesting software puzzle. However testing this isn't of great importance. When it has been submitted, please test my submission (because you can read the German) and mark the issue "Resolved". We close only issues during release review.

Thanks for volunteering to look at this. Much appreciated.

Robin

#3 Updated by Thomas Beutlich over 2 years ago

This is my attempt of a complete German translation of the help screen.

#4 Updated by Thomas Beutlich over 2 years ago

Forgot -fc and fixed some more. Attached updated patch.

#5 Updated by Robin Mills over 2 years ago

Submitted: r3560. Thank You Thomas for the patch.

May I ask you to verify this. I got the following error messages at the end of the build on MacOS-X 10.10:

/usr/bin/install -c -m 644 exiv2.1 /usr/local/share/man/man1/exiv2.1
cd po && /Applications/Xcode.app/Contents/Developer/usr/bin/make install
test ! -f ./exiv2.pot || \
      test -z "de.gmo es.gmo fi.gmo fr.gmo pl.gmo ru.gmo sk.gmo" || /Applications/Xcode.app/Contents/Developer/usr/bin/make de.gmo es.gmo fi.gmo fr.gmo pl.gmo ru.gmo sk.gmo
rm -f de.gmo && /usr/bin/msgfmt -c --statistics -o de.gmo de.po
de.po:12: warning: header field 'Language' still has the initial default value
de.po:4748: 'msgid' and 'msgstr' entries do not both end with '\n'
/usr/bin/msgfmt: found 1 fatal error
2764 translated messages, 1855 fuzzy translations, 1350 untranslated messages.
make[2]: *** [de.gmo] Error 1
make[1]: *** [stamp-po] Error 2
make: *** [install] Error 2

I have German on the terminal:

522 rmills@rmillsmm:~/gnu/exiv2/trunk $ export "LC_MESSAGES=de_DE.UTF-8 UTF-8" 
523 rmills@rmillsmm:~/gnu/exiv2/trunk $ exiv2 
exiv2: Eine Aktion muss angegeben werden
exiv2: Es muss mindestens eine Datei angegeben werden
Benutzung: exiv2 [ Optionen ] [ Aktionen ] Datei ...

"Andert die Exif-Metadaten von Bildern.
524 rmills@rmillsmm:~/gnu/exiv2/trunk $ 

#6 Updated by Niels Kristian Bech Jensen over 2 years ago

The build error is fixed in the trunk by r3561.

Best regards,
Niels Kristian Bech Jensen

#7 Updated by Robin Mills over 2 years ago

Thanks for fixing that, Niels.

#8 Updated by Thomas Beutlich over 2 years ago

  • Status changed from Assigned to Resolved

#9 Updated by Robin Mills over 2 years ago

Submitted: r3568 Thank you to Thomas Schmidt for the patch.

I received the following email from Thomas (Schmidt):

I have created the patch and as I wanted to attach it to the ticket, I saw that it was already resolved!

Since it is only 1 typo ("Jusitierung" instead of "Justierung") and the mentioned clarification (giving the action the same name as used at the beginning of the text) I do not want to reopen the ticket. And a new ticket just for this? Maybe Thomas Beutlich can add my patch to the resolve??

Allow me clarify how I use the status "Resolved" and "Closed". The status "Resolved" means this is thought to be complete, however it might receive further attention. The status "Closed" means it will not be considered again and if the matter requires further attention, a new Issue should be opened and refer to the closed issue. We only close issues during release review.

The status "Assigned" means that action is expected by the Assignee. So a "Resolved" issue may become "Assigned" if it requires further activity. If any team member is assigned an issue, and is not able to deal with the issue, it should be assigned to me for attention.

I consider my "plate" of issues to status "Assigned" where I am the Assignee.

I'd also like to say "Thank You very much" to the Thomas twins for working on this issue. Thank You, Gentlemen.

#10 Updated by Andreas Huggel over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux