Bug #1000

trivial: samsung lens id re-sorting

Added by Pascal de Bruijn over 2 years ago. Updated almost 2 years ago.

Status:ClosedStart date:19 Nov 2014
Priority:NormalDue date:
Assignee:Robin Mills% Done:

100%

Category:exif
Target version:0.25

Description

I just noticed there is a lens out of order in samsungmn.cpp:

{  4, N_("Samsung NX 20-50mm F3.5-5.6 ED")                },
{  6, N_("Samsung NX 18-200mm F3.5-6.3 ED OIS")           },
{  5, N_("Samsung NX 20mm F2.8 Pancake")                  },

It's a trivial change to swap around. Give me a bump if you'd like me to do a patch.

Associated revisions

Revision 3389
Added by Robin Mills over 2 years ago

Issue: #1000 Cosmetic code sorting issue.

History

#1 Updated by Robin Mills over 2 years ago

Congratulations Pascal on getting #1000. I was thinking of posting something minor just to get number 1000.

Are you concerned about the sorting in the code, or is the number incorrect? Which of the following is correct:

1) Cosmetic code change to sort by index:

       {  4, N_("Samsung NX 20-50mm F3.5-5.6 ED")                },
       {  5, N_("Samsung NX 20mm F2.8 Pancake")                  },
       {  6, N_("Samsung NX 18-200mm F3.5-6.3 ED OIS")           },

2) Index has been changed:

       {  4, N_("Samsung NX 20-50mm F3.5-5.6 ED")                },
       {  5, N_("Samsung NX 18-200mm F3.5-6.3 ED OIS")           },
       {  6, N_("Samsung NX 20mm F2.8 Pancake")                  },

Robin

#2 Updated by Pascal de Bruijn over 2 years ago

Ah, I hadn't noticed regarding my ticket number... Did I win a fridge or something? :D

I merely noticed the id sorting in the code was off... So the actual tuples themselves should be fine. So it's mostly a code cosmetic issue.

So number one it is. And I'm aware I'm nitpicking a bit :)

#3 Updated by Robin Mills over 2 years ago

  • Category set to exif
  • Status changed from New to Resolved
  • Assignee set to Robin Mills

You're not nit picking - you're bagging #1000. Fix submitted r3389.

Congrats on #1000. You don't win a fridge, however if you're in New York State, you've won a deep freeze (1.5m of snow last night). If you're not in New York State, you've won a Great Escape. And no matter, you get a photo of the last rose of summer in my garden.

#4 Updated by Pascal de Bruijn over 2 years ago

I'm really touched :)

#5 Updated by Robin Mills about 2 years ago

  • % Done changed from 0 to 100

#6 Updated by Andreas Huggel almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux