make gen.py Python3 compatible
|Status:||Closed||Start date:||20 Dec 2013|
|Assignee:||Robin Mills||% Done:|
In gentoo, to make documentation we've forced to use Python2 environment just to make documentation.
This patch make `gen.py` compatible w/ Python2 and 3.
#3 Updated by Robin Mills over 4 years ago
- Category set to build
- Status changed from New to Assigned
- Assignee set to Robin Mills
- Target version set to 0.25
Thanks. This feels like a painless change for us which will save you pain.
I've tried to apply this with SmartSVN and he says "This isn't a patch" or something very unfriendly. As there is only one file, may I ask you:
1) Attach the new version of gen.py for the head of trunk (r3210)
2) Both files. For doc/templates and website/bin
527 rmills@rmills-mbp:~/gnu/exiv2/trunk $ finder gen.py ./doc/templates/gen.py ./website/bin/gen.py 528 rmills@rmills-mbp:~/gnu/exiv2/trunk $ diff $(find . -name gen.py) 4c4 < vardir = "." --- > vardir = "./var" 529 rmills@rmills-mbp:~/gnu/exiv2/trunk $(website/bin/gen.py generates our on-line docs. It's almost identical to doc/templates/gen.py)
Ho Ho Ho. Happy Holidays.
#7 Updated by Robin Mills over 4 years ago
- Status changed from Assigned to Resolved
Thanks, Alex. I've submitted your changes. r3211
I've advanced this issue to "Resolved". We only close bug during the review process before we release. If we discover anything more about this between now and 0.25 we'll add notes here.
Thanks for the svn compatible patch. That worked perfectly and diff reported a match with your two versions of gen.py.
547 rmills@rmills-mbp:~/gnu/exiv2/trunk $ diff website/bin/gen.py ~/temp/patch/website/bin/gen.py 548 rmills@rmills-mbp:~/gnu/exiv2/trunk $ diff doc/templates/gen.py ~/temp/patch/doc/templates/gen.py 549 rmills@rmills-mbp:~/gnu/exiv2/trunk $If you didnt use svn to create the patch file, perhaps you could explain how it was produced. I will update our wiki and acknowledge your contribution:
Thanks very much for contributing to Exiv2. Together we all make open source work.
#9 Updated by Robin Mills over 4 years ago
I've reported this on the SmartSVN Forum. Thanks for the update.