Bug #918

non-zero exit code when extracting thumbnails

Added by Romain D. over 3 years ago. Updated over 1 year ago.

Status:ClosedStart date:25 Aug 2013
Priority:NormalDue date:
Assignee:Robin Mills% Done:

100%

Category:samples
Target version:0.26

Description

Hello,

As discussed with Robin here http://dev.exiv2.org/boards/3/topics/1602, exiv2 return a non-zero exit code after extracting thumbnail if succeeded. This is incompatible with some tools like make, which expects a 0 exit code in case of command succeeded.
Is there any reason to pass the length of the thumbnail via exit code? Can exiv2 simply return 0 in case of success?


Related issues

Related to Exiv2 - Feature #917: Modify exiv2/actions.cpp return -3/253 when no metadata h... Closed 11 Aug 2013

History

#1 Updated by Robin Mills about 2 years ago

  • Category set to samples
  • Status changed from New to Assigned
  • Assignee set to Robin Mills
  • Target version set to 0.25

This is a duplicate of #917. I'll keep it "assigned" to me until we resolve #917.

#2 Updated by Robin Mills about 2 years ago

  • Target version changed from 0.25 to 0.26

Deferred to v0.26. Insufficient time to deal with this for v0.25.

#3 Updated by Robin Mills about 2 years ago

  • Assignee deleted (Robin Mills)

#4 Updated by Robin Mills over 1 year ago

  • Assignee set to Robin Mills

#5 Updated by Robin Mills over 1 year ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

I think this matter has been fixed and can no longer be reproduced.

516 rmills@rmillsmbp:~/clanmills $ exiv2 -pp ~/temp/Stonehenge.jpg 
Preview 1: image/jpeg, 160x120 pixels, 10837 bytes
517 rmills@rmillsmbp:~/clanmills $ echo $?
0
520 rmills@rmillsmbp:~/clanmills $ exiv2 -ep --verbose ~/temp/Stonehenge.jpg 
File 1/1: /Users/rmills/temp/Stonehenge.jpg
exiv2: Overwrite `/Users/rmills/temp/Stonehenge-preview1.jpg'? y
Writing preview 1 (image/jpeg, 160x120 pixels, 10837 bytes) to file /Users/rmills/temp/Stonehenge-preview1.jpg
521 rmills@rmillsmbp:~/clanmills $ echo $?
0
522 rmills@rmillsmbp:~/clanmills $ 522 rmills@rmillsmbp:~/clanmills $ rm -rf ~/temp/Stonehenge-preview1.jpg
523 rmills@rmillsmbp:~/clanmills $ exiv2 -ep --verbose ~/temp/Stonehenge.jpg 
File 1/1: /Users/rmills/temp/Stonehenge.jpg
Writing preview 1 (image/jpeg, 160x120 pixels, 10837 bytes) to file /Users/rmills/temp/Stonehenge-preview1.jpg
524 rmills@rmillsmbp:~/clanmills $ ls -alt ~/temp/Stonehenge-preview1.jpg 
-rw-r--r--+ 1 rmills  staff  10837 15 Nov 17:17 /Users/rmills/temp/Stonehenge-preview1.jpg
525 rmills@rmillsmbp:~/clanmills $ rm -rf ~/temp/Stonehenge-preview1.jpg
526 rmills@rmillsmbp:~/clanmills $ exiv2 -ep ~/temp/Stonehenge.jpg 
527 rmills@rmillsmbp:~/clanmills $ echo $?
0
528 rmills@rmillsmbp:~/clanmills $ ls -alt ~/temp/Stonehenge-preview1.jpg 
-rw-r--r--+ 1 rmills  staff  10837 15 Nov 17:18 /Users/rmills/temp/Stonehenge-preview1.jpg
529 rmills@rmillsmbp:~/clanmills $ 522 rmills@rmillsmbp:~/clanmills $ rm -rf ~/temp/Stonehenge-preview1.jpg
523 rmills@rmillsmbp:~/clanmills $ exiv2 -ep --verbose ~/temp/Stonehenge.jpg 
File 1/1: /Users/rmills/temp/Stonehenge.jpg
Writing preview 1 (image/jpeg, 160x120 pixels, 10837 bytes) to file /Users/rmills/temp/Stonehenge-preview1.jpg
524 rmills@rmillsmbp:~/clanmills $ ls -alt ~/temp/Stonehenge-preview1.jpg 
-rw-r--r--+ 1 rmills  staff  10837 15 Nov 17:17 /Users/rmills/temp/Stonehenge-preview1.jpg
525 rmills@rmillsmbp:~/clanmills $ rm -rf ~/temp/Stonehenge-preview1.jpg
526 rmills@rmillsmbp:~/clanmills $ exiv2 -ep ~/temp/Stonehenge.jpg 
527 rmills@rmillsmbp:~/clanmills $ echo $?
0
528 rmills@rmillsmbp:~/clanmills $ ls -alt ~/temp/Stonehenge-preview1.jpg 
-rw-r--r--+ 1 rmills  staff  10837 15 Nov 17:18 /Users/rmills/temp/Stonehenge-preview1.jpg
529 rmills@rmillsmbp:~/clanmills $ 

#6 Updated by Robin Mills over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux