Bug #895

Sigma 30mm f/1.4 on Canon not detected correctly

Added by Christian Roumano over 4 years ago. Updated over 4 years ago.

Status:ClosedStart date:18 Mar 2013
Priority:NormalDue date:27 Apr 2013
Assignee:Niels Kristian Bech Jensen% Done:

100%

Category:metadataEstimated time:1.00 hour
Target version:0.24

Description

Hi,
The Sigma 30mm 1.4 is not recogize correctly (tested with the last exiv2 version) :

exiv2 -pt 1.JPG |grep -i lens
Exif.CanonCs.LensType Short 1 Sigma 15-30mm f/3.5-4.5 EX DG Aspherical
Exif.CanonCs.Lens Short 3 30.0 mm
Exif.Canon.LensModel Ascii 70 30mm

exiftool 1.JPG |grep "Lens ID"
Lens ID : Sigma 30mm f/1.4 EX DC HSM

Information in at canonmn.cpp in the Exiv2 codebase:

{ 169, "Canon EF 17-35mm f/2.8L" 
}, // 0 { 169, "Sigma 18-200mm f/3.5-6.3 DC OS"
}, // 1 { 169, "Sigma 15-30mm f/3.5-4.5 EX DG Aspherical"
}, // 2 { 169, "Sigma 18-50mm f/2.8 Macro"
}, // 3 { 169, "Sigma 50mm f/1.4 EX DG HSM"
}, // 4 { 169, "Sigma 85mm f/1.4 EX DG HSM"
}, // 5 { 169, "Sigma 30mm f/1.4 EX DC HSM"
}, // 6 { 169, "Sigma 35mm f/1.4 DG HSM"
}, // 7

So the 169 ID is used 8 times, once by Canon (expected), and seven
times by Sigma (wtf were they thinking)...

Exiv2 uses a heuristic to match conflicted lens id's to
names using their focal length's... but it's failing here somehow...

The Bug #854 as the same issue with another lens. ( Sigma 50mm f/1.4 EX DG HSM )

1.JPG - a exemple of picture with the sigma 30mm 1.4 (4.7 MB) Christian Roumano, 18 Mar 2013 12:04

Associated revisions

Revision 3023
Added by Niels Kristian Bech Jensen over 4 years ago

Issues #854 and #895: Improve the heuristic for matching Canon lenses by including maximum aperture. Patch by Aakash Goenka. Make all lens names unique.

History

#1 Updated by Aakash Goenka over 4 years ago

I have submitted a patch for Bug #854. It fixes this bug too.

#2 Updated by Niels Kristian Bech Jensen over 4 years ago

  • Due date set to 27 Apr 2013
  • Status changed from New to Resolved
  • Assignee set to Niels Kristian Bech Jensen
  • Target version set to 0.24

#3 Updated by Niels Kristian Bech Jensen over 4 years ago

  • Category set to metadata
  • % Done changed from 0 to 100

#4 Updated by Robin Mills over 4 years ago

  • Status changed from Resolved to Closed

Fixed in 0.24.

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux