Bug #875

New lens "Tamron SP 24-70mm F/2.8 Di VC USD"

Added by Jean-Pierre Verrue about 4 years ago. Updated over 3 years ago.

Status:ClosedStart date:01 Jan 2013
Priority:NormalDue date:
Assignee:Robin Mills% Done:

0%

Category:metadata
Target version:0.24

Description

New lens : "Tamron SP 24-70mm F/2.8 Di VC USD"
Can you add this lens to exiv2 library ?

exiv2 data for this lens are
Exif.Nikon3.LensType Byte 1 D G VR
Exif.Nikon3.Lens Rational 4 24-70mm F2.8
Exif.Nikon3.LensFStops Undefined 4 6
Exif.NikonLd3.LensIDNumber Byte 1 254
Exif.NikonLd3.LensFStops Byte 1 F6.0

exiftool data for this lens are
Lens Type : G VR
Lens : 24-70mm f/2.8
Lens Data Version : 0204
Lens ID Number : 254
Lens F Stops : 6.00
Lens ID : Unknown (FE 48 37 5C 24 24 DF 0E)
Lens : 24-70mm f/2.8 G VR

Thank you very much

JPV_2055.JPG (1.57 MB) Jean-Pierre Verrue, 01 Jan 2013 11:39

exiv2_Tamron_24-70mm.diff Magnifier (995 Bytes) Niels Kristian Bech Jensen, 12 Jan 2013 20:40

exiv2_Tamron_24-70mm.patch Magnifier (918 Bytes) Niels Kristian Bech Jensen, 13 Jan 2013 20:23

Associated revisions

Revision 2969
Added by Robin Mills about 4 years ago

Issue: #875. Thanks to Neils for the patch.

History

#1 Updated by Robin Mills about 4 years ago

  • Status changed from New to Feedback

Jean-Pierre

I always want to help. In this case I don't understand the code/data in nikonmn.cpp. Perhaps you can email the author referenced in the code and together you can provide a patch.

Apologies that I can't be more helpful at this time. Best Wishes for 2013.

Robin

#2 Updated by Niels Kristian Bech Jensen about 4 years ago

Here is the patch you asked for.

Regards,
Niels Kristian

#3 Updated by Jean-Pierre Verrue about 4 years ago

Thank you !

#4 Updated by Robin Mills about 4 years ago

I'm unable to use the diff file.

504 rmills@rmills-laptop:/c/gnu.test/exiv2 $ svn patch ~/Downloads/exiv2_Tamron_24-70mm.diff
Skipped missing target: 'exiv2.2967/src/nikonmn.cpp  2013-01-13 05:16:03.394295460 +0100'
Summary of conflicts:
  Skipped paths: 1
505 rmills@rmills-laptop:/c/gnu.test/exiv2 $ cd src
506 rmills@rmills-laptop:/c/gnu.test/exiv2/src $ svn patch ~/Downloads/exiv2_Tamron_24-70mm.diff
Skipped missing target: 'exiv2.2967/src/nikonmn.cpp  2013-01-13 05:16:03.394295460 +0100'
Summary of conflicts:
  Skipped paths: 1
507 rmills@rmills-laptop:/c/gnu.test/exiv2/src $

#5 Updated by Robin Mills about 4 years ago

  • Category set to metadata
  • Assignee set to Robin Mills
  • Target version set to 0.24

#6 Updated by Niels Kristian Bech Jensen about 4 years ago

I have made a new patch using svn from the top directory of the exiv2 tree.

The command to use the patch I sent you before is: patch -p1 -E -s -i ~/Downloads/exiv2_Tamron_24-70mm.diff

Regards,
Niels Kristian

#7 Updated by Robin Mills about 4 years ago

  • Status changed from Feedback to Resolved

#8 Updated by Robin Mills over 3 years ago

  • Status changed from Resolved to Closed

Fixed in 0.24.

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux