Bug #870

Exif.OlympusEq.0x0403 tag

Added by Christoph Anton Mitterer almost 5 years ago. Updated over 4 years ago.

Status:ClosedStart date:12 Dec 2012
Priority:NormalDue date:
Assignee:Robin Mills% Done:

0%

Category:metadata
Target version:0.24

Description

Hi.

It seems that the Exif.OlympusEq.0x0403 tag shows the converter lenses that can be attached to some of Olympus' compact cameras, e.g. the TG-1.

I was able to see three different values:
TCON
FCON
WCON
(but there are likely some others).

The setting is called "Conversion Lens" in the camera menu, so perhaps 0x0403 should be called "ConversionLens".

Cheers,
Chris.

images.tar.bz2 (301 KB) Christoph Anton Mitterer, 15 Jan 2013 17:30

Associated revisions

Revision 2978
Added by Robin Mills almost 5 years ago

Issue: #870. Thanks to Chris for reporting this and providing test data. Olympus ConversionLens.

History

#1 Updated by Robin Mills almost 5 years ago

  • Category changed from exif to metadata
  • Status changed from New to Assigned
  • Assignee set to Robin Mills
  • Target version set to 0.24

Chris

I'd like to fix this for you - however I'm not sure I've understood what you'd like done. Is it possible for you to provide a patch with the change. You create a patch file with the commands:

$ cd <exiv2dir>
$ svn diff > chris.patch  

#2 Updated by Christoph Anton Mitterer almost 5 years ago

Uhm what I meant was... the tag Exif.OlympusEq.0x0403 seems to be still unknown/unanmed in exiv2.

But I "found" out it's meaning; it specifies the used Conversion Lens, so one should name the tag like: Exif.OlympusEq.ConversionLens.
That's also the name AFAIK, that Phil used in Exiftool, when I told him about this tag.

Clear now? If not I try to write a patch.

Cheers,
Chris.

#3 Updated by Robin Mills almost 5 years ago

Chris

I don't pretent to be stupid, it's just that I have a rather small brain. I can see a couple of ways to fix this:

1) If you have an sample image, can you provide me with:
a) your command-line you use to produce it
b) the current output
c) and what you'd like

I think you might have done that above, but without a sample image, I'm not sure.

2) If you succeed in making the patch, you'll get exactly what you want.

Robin

#4 Updated by Christoph Anton Mitterer almost 5 years ago

Hi again..

For now just the description,... I've had a look at the source but it would need me longer time see how to introduce new tags and I'm on a trip for my institute.

Attached are some sample images.
If you do a:
$ exiv2 pr -p a P* | grep CON
$
you get nothing.

If you do though a:
$ exiv2 pr -p a -u P* | grep CON
P1160115.JPG Exif.OlympusEq.0x0403 Ascii 32 WCON
P1160116.JPG Exif.OlympusEq.0x0403 Ascii 32 FCON
P1160117.JPG Exif.OlympusEq.0x0403 Ascii 32 TCON
$

you get these yet unknown tags (with the values WCON, FCON, TCON).

What I meant was,... the meaning of these values are conversion lenses that can be plugged on the camera.

So for the benefit of all, Exif.OlympusEq.0x0403 should no longer be a unknown tag but rather be "named" Exif.OlympusEq.ConversionLens.

And the output without -u should give
$ exiv2 pr -p a -b -u P* | grep Exif.OlympusEq.0x0403
If you do though a:
$ exiv2 pr -p a P* | grep CON
P1160115.JPG Exif.OlympusEq.ConversionLens Ascii 32 WCON
P1160116.JPG Exif.OlympusEq.ConversionLens Ascii 32 FCON
P1160117.JPG Exif.OlympusEq.ConversionLens Ascii 32 TCON
$

Hope that helps,
Chris.

#5 Updated by Robin Mills almost 5 years ago

  • Status changed from Assigned to Feedback

Chris

No problem now that I understand and you have given me test data. Thanks. Enjoy your trip - wherever you are!

Fix submitted SVN r2978

1015 rmills@rmills-linux:~/gnu/exiv2/test.build/build $ bin/exiv2 pr -p a ~/Downloads/403/*.JPG | grep CON
/home/rmills/Downloads/403/P1160115.JPG  Exif.OlympusEq.ConversionLens                Ascii      32  WCON
/home/rmills/Downloads/403/P1160116.JPG  Exif.OlympusEq.ConversionLens                Ascii      32  FCON
/home/rmills/Downloads/403/P1160117.JPG  Exif.OlympusEq.ConversionLens                Ascii      32  TCON
1016 rmills@rmills-linux:~/gnu/exiv2/test.build/build $ bin/exiv2 pr -p a -u ~/Downloads/403/*.JPG | grep CON
/home/rmills/Downloads/403/P1160115.JPG  Exif.OlympusEq.ConversionLens                Ascii      32  WCON
/home/rmills/Downloads/403/P1160116.JPG  Exif.OlympusEq.ConversionLens                Ascii      32  FCON
/home/rmills/Downloads/403/P1160117.JPG  Exif.OlympusEq.ConversionLens                Ascii      32  TCON
1017 rmills@rmills-linux:~/gnu/exiv2/test.build/build $

I'll update the bug report to "Feedback". When you agree that it's been dealt with, please change it to "Resolved". It will get closed when we finish the 0.24 version of exiv2.

Robin

#6 Updated by Niels Kristian Bech Jensen almost 5 years ago

Hi Robin.

For consistency I think you should write "Conversion lens" with a lower-case "l" in the second of the two translatable strings.

Regards,
Niels Kristian

#7 Updated by Robin Mills almost 5 years ago

Thanks for pointing that out Niels. I've updated the code. r2979 I didn't notice that - thanks for keeping me honest.

        TagInfo(0x0303, "ExtenderModel", N_("Extender Model"), N_("Extender model"), olympusEqId, makerTags, asciiString, -1, printValue),
        TagInfo(0x0304, "ExtenderFirmwareVersion", N_("Extender Firmware Version"), N_("Extender firmwareversion"), olympusEqId, makerTags, unsignedLong, -1, printValue),
        TagInfo(0x0403, "ConversionLens", N_("Conversion Lens"), N_("Conversion lens"), olympusEqId, makerTags, asciiString, -1, printValue),
        TagInfo(0x1000, "FlashType", N_("Flash Type"), N_("Flash type"), olympusEqId, makerTags, unsignedShort, -1, EXV_PRINT_TAG(olympusEqFlashType)),

#8 Updated by Christoph Anton Mitterer almost 5 years ago

Hey guys :)

Just one thing with respect to the case:
I think it's always good if the tag names are identical to those used by exiftool, which is currently the case right?
I had proposed ConversionLens to Phil Harvey, so he might have used the capital "L"... can you sort this out with him?

Cheers,
Chris.

#9 Updated by Niels Kristian Bech Jensen almost 5 years ago

Hi Chris.

The tag name is exactly the same as in ExifTool 9.13. The change was to the tag description which ExifTool does not have.

Regards,
Niels Kristian

#10 Updated by Robin Mills almost 5 years ago

  • Status changed from Feedback to Resolved

I'm a little confused (well, I'm often a little confused!).

Chris: I think you're saying that the name "Conversion Lens" is a proposal for ExifTool - and Phil may use a different name when he adds it. I agree that we should be consistent. If ExifTool uses a different name, please update this issue, and change the status to "Assigned" and I'll change exiv2 appropriately.

For now, I've marked this as "Resolved" and it'll be closed during the 0.24 release.
(After it's closed, you have to open a new issue to reconsider the matter.).

Robin

#11 Updated by Christoph Anton Mitterer almost 5 years ago

Hi.

I just said he might, in the sense I've had no written contract that he'd use my proposed name ;)

Looking at http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Olympus.html
He used:
0x0403 ConversionLens string

So I guess the bug can remain closed.

Cheers,
Chris.

#12 Updated by Robin Mills over 4 years ago

  • Status changed from Resolved to Closed

Fixed in 0.24.

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux