Feature #742

External XMPSDK and/or XMPSDK 2014.12

Added by Nikolai Saoukh over 6 years ago. Updated almost 2 years ago.

Status:ClosedStart date:23 Nov 2010
Priority:NormalDue date:
Assignee:Andreas Huggel% Done:

100%

Category:xmpEstimated time:1.00 hour
Target version:0.26

Description

Can xmp (sdk) be made external project?

If not, then can xmpsdk 5.1.2 be imported?


Related issues

Related to Exiv2 - Bug #751: adobe xmp namespace Closed 17 Jan 2011
Related to Exiv2 - Patch #786: thread safety of xmp toolkit Closed 10 Aug 2011
Related to Exiv2 - Feature #941: Upgrade xmpsdk source to Adobe's current version Assigned 27 Dec 2013

History

#1 Updated by Andreas Huggel over 6 years ago

Can xmp (sdk) be made external project?

That's the goal. Or it was. See doc/README-XMP. In the meantime, the exiv2 version of XMP-SDK has changes beyond simple compiler warning fixes.

If not, then can xmpsdk 5.1.2 be imported?

Yes, thanks for the pointer.

#2 Updated by Alan Pater over 2 years ago

  • Subject changed from External XMPSDK and/or XMPSDK 5.1.2 to External XMPSDK and/or XMPSDK 2014.12

Exempi recently updated to xmpsdk 2014.12.

http://cgit.freedesktop.org/exempi/tree/NEWS

Is that the external project mentioned?

#3 Updated by Robin Mills over 2 years ago

  • Category set to xmp
  • Status changed from New to Assigned
  • Assignee set to Andreas Huggel
  • Priority changed from Low to Normal
  • Target version set to 0.26

Alan

I'm not certain what exempi is. I think it might be a snap-shot of Adobe's public offering at some time in the past. Andreas has accepted the challenge of upgrading our XMP code to the latest public offering from Adobe. This is no trivial, there are changes which have to me made to Adobe's code to integrate correctly with Exiv2. #941

There was a recent discussion (on private email) with our friends at Alien Skin Software about using both libexiv2 and Adobe's XMPsdk in the same application. I believe that was successfully concluded with a little bit of namespace massage. I'll email Alien Skin to find out if they are happy.

Here's my latest email with them about using Adobe XMPsdk and Exiv2 in the same application. (2015-02-10)

There’s the issue:
677 rmills@rmillsmbp:~/gnu/exiv2/trunk $ find . -type f -exec grep -H sXMP_InitCount $___
./xmpsdk/src/XMPCore_Impl.cpp:XMP_Int32 sXMP_InitCount = 0;
./xmpsdk/src/XMPCore_Impl.hpp:extern XMP_Int32 sXMP_InitCount;
./xmpsdk/src/XMPCore_Impl.hpp:// ! Don't do the initialization check (sXMP_InitCount > 0) for the no-lock case. That macro is used
./xmpsdk/src/XMPCore_Impl.hpp:    XMP_Assert ( sXMP_InitCount > 0 );                        \
./xmpsdk/src/XMPMeta.cpp:    ++sXMP_InitCount;
./xmpsdk/src/XMPMeta.cpp:    if ( sXMP_InitCount > 1 ) return true;
./xmpsdk/src/XMPMeta.cpp:    --sXMP_InitCount;
./xmpsdk/src/XMPMeta.cpp:    if ( sXMP_InitCount > 0 ) return;
678 rmills@rmillsmbp:~/gnu/exiv2/trunk $ 

That variable sXMP_InitCount isn’t static.  It’s extern and that why it’s visible in xmpsdk.lib

Wrapping it (and his companions) in the Exiv2 namespace OR changing the name to sXMP_InitCount__ will almost certainly fix it.

I'm going to assign this (#742) to Andreas to be considered in the XMP upgrade project for v0.26.

#4 Updated by Robin Mills almost 2 years ago

  • Status changed from Assigned to Closed
  • Estimated time set to 1.00

I'm going to mark this as "Closed". It will be dealt with when we update XMPsdk in #941.

#5 Updated by Robin Mills almost 2 years ago

  • % Done changed from 0 to 100

Also available in: Atom PDF

Redmine Appliance - Powered by TurnKey Linux